Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2816733004: MIPS64: Fix "[ignition] Add call bytecodes for undefined receiver" (Closed)

Created:
3 years, 8 months ago by predrag.rudic
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix "[ignition] Add call bytecodes for undefined receiver" Fix 751e89359123df4f6e5f0b28b89fcdf63ed16a77 commit Fix typo in implementation BUG= Review-Url: https://codereview.chromium.org/2816733004 Cr-Commit-Position: refs/heads/master@{#44676} Committed: https://chromium.googlesource.com/v8/v8/+/8cb861bf72a8188759237ca1ac5345c03dad29f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
predrag.rudic
PTAL
3 years, 8 months ago (2017-04-13 15:29:19 UTC) #4
Leszek Swirski
lgtm, thanks for the catch
3 years, 8 months ago (2017-04-13 15:39:53 UTC) #5
Michael Achenbach
lgtm, please leave an empty line after first line in CL description.
3 years, 8 months ago (2017-04-13 17:43:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816733004/1
3 years, 8 months ago (2017-04-18 08:48:04 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 08:49:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8cb861bf72a8188759237ca1ac5345c03da...

Powered by Google App Engine
This is Rietveld 408576698