🔍 Update how shared preferences are handled by the widget

🔍 Update how shared preferences are handled by the widget

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

Minor things:
* Set a background color explicitly so that it doesn't come up white.

* Remove Herb-related launching.

BUG=708844, 710943, 710947
Review-Url: https://codereview.chromium.org/2816733003
Cr-Commit-Position: refs/heads/master@{#464605}
Committed: https://chromium.googlesource.com/chromium/src/+/8ef9faffba78738c37df77a160fea80ee5f604af

[gone, 2017-04-12 23:13:54]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org, yusufo@chromium.org

[gone, 2017-04-12 23:14:16]

Description was changed from

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I dbout it helps much,
  and it complicates the code a bit.

BUG=708844
==========

to

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I dbout it helps much,
  and it complicates the code a bit.

BUG=708844
==========

[gone, 2017-04-12 23:15:32]

Description was changed from

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I dbout it helps much,
  and it complicates the code a bit.

BUG=708844
==========

to

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I dbout it helps much,
  and it complicates the code a bit.

BUG=708844,710943
==========

[gone, 2017-04-13 01:27:14]

Description was changed from

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I dbout it helps much,
  and it complicates the code a bit.

BUG=708844,710943
==========

to

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

BUG=708844,710943,710947
==========

[gone, 2017-04-13 01:29:43]

Description was changed from

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

BUG=708844,710943,710947
==========

to

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

BUG=708844,710943,710947
==========

[gone, 2017-04-13 01:31:01]

Description was changed from

==========
🔍 Update how shared preferences are cached

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

BUG=708844,710943,710947
==========

to

==========
🔍 Update how shared preferences are handled by the widget

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

BUG=708844,710943,710947
==========

[gone, 2017-04-13 20:14:16]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 20:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:55:00]

Dry run: This issue passed the CQ dry run.

[gone, 2017-04-13 21:26:11]

Description was changed from

==========
🔍 Update how shared preferences are handled by the widget

* Remove Herb-related launching.

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

BUG=708844,710943,710947
==========

to

==========
🔍 Update how shared preferences are handled by the widget

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

Minor things:
* Set a background color explicitly so that it doesn't come up white.

* Remove Herb-related launching.

BUG=708844,710943,710947
==========

[gone, 2017-04-13 21:27:53]

Assuming you hadn't had time to look at this yet, so I threw on a background
color fix in PS4.

[Ted C, 2017-04-13 21:31:23]

lgtm

https://codereview.chromium.org/2816733003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2816733003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:219:
/*
?

[gone, 2017-04-13 22:41:34]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-04-13 22:41:35]

https://codereview.chromium.org/2816733003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
(right):

https://codereview.chromium.org/2816733003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java:219:
/*
On 2017/04/13 at 21:31:23, Ted C wrote:
> ?

Bad cherry-pick :/

[gone, 2017-04-13 22:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2816733003/#ps100001
(title: "Ugh eclipse")

[commit-bot: I haz the power, 2017-04-13 22:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 23:30:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492123294773580,
"parent_rev": "df9b67eb9751650cebee13333ab125bb3f11df75", "commit_rev":
"8ef9faffba78738c37df77a160fea80ee5f604af"}

[commit-bot: I haz the power, 2017-04-13 23:30:59]

Description was changed from

==========
🔍 Update how shared preferences are handled by the widget

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

Minor things:
* Set a background color explicitly so that it doesn't come up white.

* Remove Herb-related launching.

BUG=708844,710943,710947
==========

to

==========
🔍 Update how shared preferences are handled by the widget

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

Minor things:
* Set a background color explicitly so that it doesn't come up white.

* Remove Herb-related launching.

BUG=708844,710943,710947

Review-Url: https://codereview.chromium.org/2816733003
Cr-Commit-Position: refs/heads/master@{#464605}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ef9faffba78738c37df77a160fe...
==========

[commit-bot: I haz the power, 2017-04-13 23:31:01]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8ef9faffba78738c37df77a160fe...