| Index: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
|
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
|
| index 607077913d86af635d7890ef8abb1cd2128ce943..268ae51d33a68c584ff748812d9b55822fb3429d 100644
|
| --- a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
|
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
|
| @@ -189,8 +189,13 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
|
|
|
| mBitmapDetails = bitmapDetails;
|
| setItem(bitmapDetails);
|
| - setThumbnailBitmap(thumbnail);
|
| - mImageLoaded = !placeholder;
|
| + if (isCameraTile() || isGalleryTile()) {
|
| + initializeSpecialTile(mBitmapDetails);
|
| + mImageLoaded = true;
|
| + } else {
|
| + setThumbnailBitmap(thumbnail);
|
| + mImageLoaded = !placeholder;
|
| + }
|
|
|
| updateSelectionState();
|
| }
|
| @@ -217,8 +222,6 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
|
| mSpecialTile, null, image, null, null);
|
| mSpecialTile.setText(labelStringId);
|
|
|
| - initialize(bitmapDetails, null, false);
|
| -
|
| // Reset visibility, since #initialize() sets mSpecialTile visibility to GONE.
|
| mSpecialTile.setVisibility(View.VISIBLE);
|
| }
|
| @@ -266,6 +269,7 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
|
| * re-used.
|
| */
|
| private void resetTile() {
|
| + mIconView.setImageBitmap(null);
|
| mUnselectedView.setVisibility(View.GONE);
|
| mSelectedView.setVisibility(View.GONE);
|
| mScrim.setVisibility(View.GONE);
|
| @@ -323,15 +327,14 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
|
| }
|
|
|
| private boolean isGalleryTile() {
|
| - // TODO(finnur): Remove the null checks here and below.
|
| - return mBitmapDetails != null && mBitmapDetails.type() == PickerBitmap.GALLERY;
|
| + return mBitmapDetails.type() == PickerBitmap.GALLERY;
|
| }
|
|
|
| private boolean isCameraTile() {
|
| - return mBitmapDetails != null && mBitmapDetails.type() == PickerBitmap.CAMERA;
|
| + return mBitmapDetails.type() == PickerBitmap.CAMERA;
|
| }
|
|
|
| private boolean isPictureTile() {
|
| - return mBitmapDetails == null || mBitmapDetails.type() == PickerBitmap.PICTURE;
|
| + return mBitmapDetails.type() == PickerBitmap.PICTURE;
|
| }
|
| }
|
|
|