Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java

Issue 2816733002: Photo Picker Dialog: Use sandboxed utility process for decoding images. (Closed)
Patch Set: Address comments from Theresa Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java
index 2b64157e436711fa8bc78bf667f160887115a10a..66cfc4512e6a3a81e5f99ed398d44cc5784bde2f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java
@@ -10,6 +10,7 @@ import android.webkit.MimeTypeMap;
import java.io.File;
import java.io.FileFilter;
import java.util.HashSet;
+import java.util.List;
import java.util.Locale;
/**
@@ -23,13 +24,12 @@ class MimeTypeFileFilter implements FileFilter {
/**
* Contructs a MimeTypeFileFilter object.
- * @param acceptAttr A comma seperated list of MIME types this filter accepts.
- * For example: images/gif, video/*.
+ * @param mimeTypes A list of MIME types this filter accepts.
+ * For example: images/gif, video/*.
*/
- // TODO(finnur): Convert param to List.
- public MimeTypeFileFilter(@NonNull String acceptAttr) {
- for (String field : acceptAttr.toLowerCase(Locale.US).split(",")) {
- field = field.trim();
+ public MimeTypeFileFilter(@NonNull List<String> mimeTypes) {
+ for (String field : mimeTypes) {
+ field = field.trim().toLowerCase(Locale.US);
if (field.startsWith(".")) {
mExtensions.add(field.substring(1));
} else if (field.endsWith("/*")) {

Powered by Google App Engine
This is Rietveld 408576698