[arm] Remove embedded constant pool support.

[arm] Remove embedded constant pool support.

This option doesn't work for ARM any more.

BUG=

Review-Url: https://codereview.chromium.org/2816703002
Cr-Commit-Position: refs/heads/master@{#44646}
Committed: https://chromium.googlesource.com/v8/v8/+/c4b02905d82dd502c278968eab76f17c7d6d533f

[georgia.kouveli, 2017-04-12 11:03:23]

georgia.kouveli@arm.com changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[Benedikt Meurer, 2017-04-13 04:53:07]

LGTM from my side

[rmcilroy, 2017-04-13 09:45:07]

LGTM, thanks.

https://codereview.chromium.org/2816703002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2816703002/diff/1/src/arm/assembler-arm.cc#ne...
src/arm/assembler-arm.cc:1167: DCHECK(!x.must_output_reloc_info(this));
nit - could you add a comment here that use_mov_immediate_load should return
false when Operand::must_output_reloc_info since we prefer the constant pool for
patched values.

[georgia.kouveli, 2017-04-13 13:02:14]

The CQ bit was checked by georgia.kouveli@arm.com

[georgia.kouveli, 2017-04-13 13:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2816703002/#ps20001
(title: "[arm] Remove embedded constant pool support.")

[commit-bot: I haz the power, 2017-04-13 13:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 13:32:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492088534910760,
"parent_rev": "dc83caa6fbf659a701f2f78033e70802cbd60470", "commit_rev":
"c4b02905d82dd502c278968eab76f17c7d6d533f"}

[commit-bot: I haz the power, 2017-04-13 13:32:40]

Description was changed from

==========
[arm] Remove embedded constant pool support.

This option doesn't work for ARM any more.

BUG=
==========

to

==========
[arm] Remove embedded constant pool support.

This option doesn't work for ARM any more.

BUG=

Review-Url: https://codereview.chromium.org/2816703002
Cr-Commit-Position: refs/heads/master@{#44646}
Committed:
https://chromium.googlesource.com/v8/v8/+/c4b02905d82dd502c278968eab76f17c7d6...
==========

[commit-bot: I haz the power, 2017-04-13 13:32:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c4b02905d82dd502c278968eab76f17c7d6...