Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2816633002: bootstrap: Invoke "pip" through Python. (Closed)

Created:
3 years, 8 months ago by dnj
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bootstrap: Invoke "pip" through Python. Invoking "pip" as a command-line executable falls into the problem of shebang length truncation if checked out into a too-long subdirectory. Invoke "pip" through the Python binary. BUG=None TEST=None Review-Url: https://codereview.chromium.org/2816633002 Committed: https://github.com/luci/recipes-py/commit/5a74d04e181b07592fb57abd5602bafe276e2b17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M bootstrap/bootstrap.py View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
iannucci
lgtm
3 years, 8 months ago (2017-04-11 20:57:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816633002/1
3 years, 8 months ago (2017-04-11 21:00:09 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:03:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/5a74d04e181b07592fb57abd5602bafe276...

Powered by Google App Engine
This is Rietveld 408576698