Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

This patch updates the slimming paint v2 trybot to run with
dcheck_always_on.

BUG=702805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2816613002
Cr-Commit-Position: refs/heads/master@{#464071}
Committed: https://chromium.googlesource.com/chromium/src/+/d850820a384d5cad1cbbcdfc209becdaf6beae88

[pdr., 2017-04-11 18:44:33]

pdr@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org

[pdr., 2017-04-11 18:44:59]

Description was changed from

==========
Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

This patch updates the slimming paint v2 trybot to run with
dcheck_always_on.

BUG=702805
==========

to

==========
Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

This patch updates the slimming paint v2 trybot to run with
dcheck_always_on.

BUG=702805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-11 18:45:41]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 18:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-04-11 18:47:22]

Dirk and Paweł,

This is my first time touching this sort of config file. I think this change is
correct but please review this like I have no idea what I'm doing.

[Dirk Pranke, 2017-04-11 18:56:33]

You realize that if you enable DCHECKs the layout test expectations don't really
work right, right?

[pdr., 2017-04-11 20:37:59]

On 2017/04/11 at 18:56:33, dpranke wrote:
> You realize that if you enable DCHECKs the layout test expectations don't
really work right, right?

I didn't realize that. Why is that the case?

I prepared for enabling dchecks by running the layout tests with dchecks on and
adding ~200 lines that are crashing with dchecks. I was expecting the
expectations to work though.

[Dirk Pranke, 2017-04-11 21:19:33]

On 2017/04/11 20:37:59, pdr. wrote:
> On 2017/04/11 at 18:56:33, dpranke wrote:
> > You realize that if you enable DCHECKs the layout test expectations don't
> really work right, right?
> 
> I didn't realize that. Why is that the case?
> 
> I prepared for enabling dchecks by running the layout tests with dchecks on
and
> adding ~200 lines that are crashing with dchecks. I was expecting the
> expectations to work though.

The "Release" and "Debug" configurations in TestExpectations match what the
waterfalls
are (release build + no dcheck, full debug including dcheck).

When you run a build with release+dcheck, the dchecks trigger, and you get many
of the failures you'd expect from a Debug build, but you're in the wrong
configuration. So, your results don't necessarily match release, and they don't
necessarily match full debug. And, we don't support a third configuration.

This doesn't happen all the time, but it does happen some of the time.

When we run the layout tests on the CQ builders, dchecks are also enabled, so I
think most of the failures are already accounted for, but I wanted to make sure
you understood what would happen.

LGTM if you want to land this.

[commit-bot: I haz the power, 2017-04-11 21:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:30:36]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[pdr., 2017-04-11 22:26:23]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 00:57:12]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-04-12 13:37:05]

LGTM

[pdr., 2017-04-12 17:30:35]

On 2017/04/11 at 21:19:33, dpranke wrote:
> On 2017/04/11 20:37:59, pdr. wrote:
> > On 2017/04/11 at 18:56:33, dpranke wrote:
> > > You realize that if you enable DCHECKs the layout test expectations don't
> > really work right, right?
> > 
> > I didn't realize that. Why is that the case?
> > 
> > I prepared for enabling dchecks by running the layout tests with dchecks on
and
> > adding ~200 lines that are crashing with dchecks. I was expecting the
> > expectations to work though.
> 
> The "Release" and "Debug" configurations in TestExpectations match what the
waterfalls
> are (release build + no dcheck, full debug including dcheck).
> 
> When you run a build with release+dcheck, the dchecks trigger, and you get
many of the failures you'd expect from a Debug build, but you're in the wrong
configuration. So, your results don't necessarily match release, and they don't
necessarily match full debug. And, we don't support a third configuration.
> 
> This doesn't happen all the time, but it does happen some of the time.
> 
> When we run the layout tests on the CQ builders, dchecks are also enabled, so
I think most of the failures are already accounted for, but I wanted to make
sure you understood what would happen.
> 
> LGTM if you want to land this.

Thank you for the info! I did not know about this, but I'm familiar with the
release+dcheck weirdness. I will keep this in mind.

[pdr., 2017-04-12 17:30:39]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-04-12 17:30:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2816613002/#ps20001
(title: "Update expectations")

[commit-bot: I haz the power, 2017-04-12 17:31:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:41:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492018239080760,
"parent_rev": "91b3f7e7b1f592052614ffd6eb61d60f87dd2571", "commit_rev":
"d850820a384d5cad1cbbcdfc209becdaf6beae88"}

[commit-bot: I haz the power, 2017-04-12 17:42:28]

Description was changed from

==========
Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

This patch updates the slimming paint v2 trybot to run with
dcheck_always_on.

BUG=702805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make linux_layout_tests_slimming_paint_v2 run with dcheck_always_on

This patch updates the slimming paint v2 trybot to run with
dcheck_always_on.

BUG=702805
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2816613002
Cr-Commit-Position: refs/heads/master@{#464071}
Committed:
https://chromium.googlesource.com/chromium/src/+/d850820a384d5cad1cbbcdfc209b...
==========

[commit-bot: I haz the power, 2017-04-12 17:42:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d850820a384d5cad1cbbcdfc209b...