[subresource_filter] Don't regress the Mac UI

[subresource_filter] Don't regress the Mac UI

The Mac UI was not updated in [1] when it probably should have. To
ensure code does not stay broken past M59 branch point, just ensure that
the existing UI can co-exist with the new UI

[1]: https://codereview.chromium.org/2793413002
BUG=689992
Review-Url: https://codereview.chromium.org/2816593005
Cr-Commit-Position: refs/heads/master@{#464126}
Committed: https://chromium.googlesource.com/chromium/src/+/dda3a2b272de6426c2d1da121731d8acd016569f

[Charlie Harrison, 2017-04-12 04:32:14]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-04-12 04:38:24]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:38:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 05:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 05:30:58]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2017-04-12 11:55:46]

csharrison@chromium.org changed reviewers:
+ melandory@chromium.org

[Charlie Harrison, 2017-04-12 11:55:46]

It looks like the linked CL broke Mac UI. Let's try to get this fix in before
branch point.

[melandory, 2017-04-12 12:05:27]

On 2017/04/12 11:55:46, Charlie Harrison wrote:
> It looks like the linked CL broke Mac UI. Let's try to get this fix in before
> branch point.

lgtm

[Charlie Harrison, 2017-04-12 12:07:10]

csharrison@chromium.org changed reviewers:
+ bauerb@chromium.org

[Charlie Harrison, 2017-04-12 12:07:11]

bauerb: PTAL?

[Bernhard Bauer, 2017-04-12 17:19:53]

lgtm

https://codereview.chromium.org/2816593005/diff/20001/chrome/browser/ui/conte...
File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right):

https://codereview.chromium.org/2816593005/diff/20001/chrome/browser/ui/conte...
chrome/browser/ui/content_settings/content_setting_bubble_model.cc:1262:
subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
Nit: You could use auto here.

[Charlie Harrison, 2017-04-12 18:05:33]

Thanks

https://codereview.chromium.org/2816593005/diff/20001/chrome/browser/ui/conte...
File chrome/browser/ui/content_settings/content_setting_bubble_model.cc (right):

https://codereview.chromium.org/2816593005/diff/20001/chrome/browser/ui/conte...
chrome/browser/ui/content_settings/content_setting_bubble_model.cc:1262:
subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
On 2017/04/12 17:19:53, Bernhard Bauer wrote:
> Nit: You could use auto here.

Done here and below.

[Charlie Harrison, 2017-04-12 18:05:55]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2017-04-12 18:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
melandory@chromium.org
Link to the patchset: https://codereview.chromium.org/2816593005/#ps40001
(title: "[subresource_filter] Don't regress the Mac UI")

[commit-bot: I haz the power, 2017-04-12 18:06:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:08:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492020355012760,
"parent_rev": "07077943755bf2cf166a2fe8c2aaab6fd46142b6", "commit_rev":
"dda3a2b272de6426c2d1da121731d8acd016569f"}

[commit-bot: I haz the power, 2017-04-12 20:08:57]

Description was changed from

==========
[subresource_filter] Don't regress the Mac UI

The Mac UI was not updated in [1] when it probably should have. To
ensure code does not stay broken past M59 branch point, just ensure that
the existing UI can co-exist with the new UI

[1]: https://codereview.chromium.org/2793413002
BUG=689992
==========

to

==========
[subresource_filter] Don't regress the Mac UI

The Mac UI was not updated in [1] when it probably should have. To
ensure code does not stay broken past M59 branch point, just ensure that
the existing UI can co-exist with the new UI

[1]: https://codereview.chromium.org/2793413002
BUG=689992

Review-Url: https://codereview.chromium.org/2816593005
Cr-Commit-Position: refs/heads/master@{#464126}
Committed:
https://chromium.googlesource.com/chromium/src/+/dda3a2b272de6426c2d1da121731...
==========

[commit-bot: I haz the power, 2017-04-12 20:08:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dda3a2b272de6426c2d1da121731...