Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2816553002: MD Settings: fix visual glitch in a11y section (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, hcarmona
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix visual glitch in a11y section Before & after: http://imgur.com/a/1yRPC (after is righter-aligned) R=dmazzoni@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2816553002 Cr-Commit-Position: refs/heads/master@{#463719} Committed: https://chromium.googlesource.com/chromium/src/+/d975472ce845091000c8fe68a18f8d93d6b1511d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Beam
3 years, 8 months ago (2017-04-11 16:45:18 UTC) #2
Dan Beam
if it's not clear, the ==0 toggle button is supposed to be aligned at the ...
3 years, 8 months ago (2017-04-11 19:08:55 UTC) #7
dmazzoni
lgtm
3 years, 8 months ago (2017-04-11 19:13:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816553002/1
3 years, 8 months ago (2017-04-11 19:14:40 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 19:22:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d975472ce845091000c8fe68a18f...

Powered by Google App Engine
This is Rietveld 408576698