Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html deterministic

Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html deterministic

Make sure the interval timer always runs the same number of times before
the test output is captured. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
Review-Url: https://codereview.chromium.org/2816543003
Cr-Commit-Position: refs/heads/master@{#464006}
Committed: https://chromium.googlesource.com/chromium/src/+/5e8b879a3d5ff5e387bb965d732441d71bf6af7c

[Sami, 2017-04-12 10:18:25]

Description was changed from

==========
skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html fix

Make sure the interval timer always runs the same number of times before
the test output is capture. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
==========

to

==========
Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html
deterministic

Make sure the interval timer always runs the same number of times before
the test output is capture. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
==========

[Sami, 2017-04-12 10:19:18]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 10:19:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-04-12 10:24:15]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org

[Sami, 2017-04-12 10:24:24]

Description was changed from

==========
Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html
deterministic

Make sure the interval timer always runs the same number of times before
the test output is capture. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
==========

to

==========
Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html
deterministic

Make sure the interval timer always runs the same number of times before
the test output is captured. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
==========

[alex clarke (OOO till 29th), 2017-04-12 10:34:35]

https://codereview.chromium.org/2816543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/block/skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed-expected.txt
(right):

https://codereview.chromium.org/2816543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed-expected.txt:1:
PASS PASS PASSPASS
The deleted expects had the word pass 4x, why do we have it 6x here?

[commit-bot: I haz the power, 2017-04-12 11:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 11:20:53]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-04-12 11:45:46]

https://codereview.chromium.org/2816543003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/block/skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed-expected.txt
(right):

https://codereview.chromium.org/2816543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/block/skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed-expected.txt:1:
PASS PASS PASSPASS
On 2017/04/12 10:34:35, alex clarke wrote:
> The deleted expects had the word pass 4x, why do we have it 6x here?

The pictures had 6x PASS which I'm trying to match here. I think there might be
a race condition when the layout information is dumped vs. when the screenshot
is captured because the test was running an unrestricted setInterval loop. 6x
PASS is what the page settles at so I think that was intended to be tested.

[alex clarke (OOO till 29th), 2017-04-12 12:43:11]

OK strange I guess this is fine :)

[alex clarke (OOO till 29th), 2017-04-12 12:59:19]

lgtm

[Sami, 2017-04-12 12:59:27]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2017-04-12 12:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 13:03:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492001967279730, "parent_rev":
"80a544628c10dd3fa27936f69d94b1fb1a1327ab", "commit_rev":
"5e8b879a3d5ff5e387bb965d732441d71bf6af7c"}

[commit-bot: I haz the power, 2017-04-12 13:04:47]

Description was changed from

==========
Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html
deterministic

Make sure the interval timer always runs the same number of times before
the test output is captured. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001
==========

to

==========
Make skip-cleaning-up-anonymous-wrappers-when-subtree-being-destroyed.html
deterministic

Make sure the interval timer always runs the same number of times before
the test output is captured. Also, since this test is just checking that
we don't crash, there's no need to verify the renderer output.

BUG=696001

Review-Url: https://codereview.chromium.org/2816543003
Cr-Commit-Position: refs/heads/master@{#464006}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e8b879a3d5ff5e387bb965d7324...
==========

[commit-bot: I haz the power, 2017-04-12 13:04:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e8b879a3d5ff5e387bb965d7324...