components/sync_preferences/pref_model_associator.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_preferences/pref_model_associator.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_preferences/pref_model_associator.cc

diff --git a/components/sync_preferences/pref_model_associator.cc b/components/sync_preferences/pref_model_associator.cc

index 6bb1801dc52a0ce53b1d64d4449b331e133164d8..bf7a081069c34db39d4ab18483fdf8d1e4b7c0c6 100644

--- a/components/sync_preferences/pref_model_associator.cc

+++ b/components/sync_preferences/pref_model_associator.cc

@@ -291,7 +291,7 @@

base::ListValue* result = to_list_value.DeepCopy();

for (const auto& value : from_list_value) {

- result->AppendIfNotPresent(value.CreateDeepCopy());

+ result->AppendIfNotPresent(value->CreateDeepCopy());

}

return result;

}