Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromeos/dbus/fake_shill_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/synchronized_minidump_manager.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager.cc b/chromecast/crash/linux/synchronized_minidump_manager.cc
index 49cb3ddf34234993c01789b802baa8b76db5792c..4f1b79180f5f97eaa2f1d5288cee73393bb7475b 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager.cc
@@ -267,7 +267,7 @@
std::string lockfile;
for (const auto& elem : *dumps) {
- std::unique_ptr<std::string> dump_info = SerializeToJson(elem);
+ std::unique_ptr<std::string> dump_info = SerializeToJson(*elem);
RCHECK(dump_info, false);
lockfile += *dump_info;
lockfile += "\n"; // Add line seperatators
@@ -332,7 +332,7 @@
std::vector<std::unique_ptr<DumpInfo>> dumps;
for (const auto& elem : *dumps_) {
- dumps.push_back(std::unique_ptr<DumpInfo>(new DumpInfo(&elem)));
+ dumps.push_back(std::unique_ptr<DumpInfo>(new DumpInfo(elem.get())));
}
return dumps;
« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromeos/dbus/fake_shill_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698