components/error_page/common/localized_error.cc - Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/common/localized_error.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/common/localized_error.cc

diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc

index 9047cdc515912f726837b7fa3cd2910550b39dc3..5192a110541d9c3930529501b2365991e3e18c29 100644

--- a/components/error_page/common/localized_error.cc

+++ b/components/error_page/common/localized_error.cc

@@ -757,9 +757,6 @@

l10n_util::GetStringUTF16(body_message_id));

}

list->Append(base::WrapUnique(suggestion_list_item));

- // |suggestion_list_item| is invalidated at this point, so it needs to be

- // reset.

- list->GetDictionary(list->GetSize() - 1, &suggestion_list_item);

return suggestion_list_item;

}