Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: extensions/renderer/api_binding.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handlers/requirements_info.cc ('k') | extensions/renderer/api_event_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding.cc
diff --git a/extensions/renderer/api_binding.cc b/extensions/renderer/api_binding.cc
index 8b36c2d70065f08b9f59583d39a90a8135fafa19..6c3cc2ee81bbcd17838144bff8044a36ead46c14 100644
--- a/extensions/renderer/api_binding.cc
+++ b/extensions/renderer/api_binding.cc
@@ -180,7 +180,7 @@
if (function_definitions) {
for (const auto& func : *function_definitions) {
const base::DictionaryValue* func_dict = nullptr;
- CHECK(func.GetAsDictionary(&func_dict));
+ CHECK(func->GetAsDictionary(&func_dict));
std::string name;
CHECK(func_dict->GetString("name", &name));
@@ -197,7 +197,7 @@
if (type_definitions) {
for (const auto& type : *type_definitions) {
const base::DictionaryValue* type_dict = nullptr;
- CHECK(type.GetAsDictionary(&type_dict));
+ CHECK(type->GetAsDictionary(&type_dict));
std::string id;
CHECK(type_dict->GetString("id", &id));
auto argument_spec = base::MakeUnique<ArgumentSpec>(*type_dict);
@@ -222,7 +222,7 @@
if (type_dict->GetList("functions", &type_functions)) {
for (const auto& func : *type_functions) {
const base::DictionaryValue* func_dict = nullptr;
- CHECK(func.GetAsDictionary(&func_dict));
+ CHECK(func->GetAsDictionary(&func_dict));
std::string function_name;
CHECK(func_dict->GetString("name", &function_name));
@@ -240,7 +240,7 @@
events_.reserve(event_definitions->GetSize());
for (const auto& event : *event_definitions) {
const base::DictionaryValue* event_dict = nullptr;
- CHECK(event.GetAsDictionary(&event_dict));
+ CHECK(event->GetAsDictionary(&event_dict));
std::string name;
CHECK(event_dict->GetString("name", &name));
std::string full_name =
@@ -265,8 +265,8 @@
const base::ListValue* list = nullptr;
CHECK(options->GetList(name, &list));
for (const auto& entry : *list) {
- DCHECK(entry.is_string());
- out_value->push_back(entry.GetString());
+ DCHECK(entry->is_string());
+ out_value->push_back(entry->GetString());
}
};
get_values("actions", &rule_actions);
« no previous file with comments | « extensions/common/manifest_handlers/requirements_info.cc ('k') | extensions/renderer/api_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698