[ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single}

[ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single}

This CL introduces methods Modulator::Fetch{Tree,TreeInternal,Single}.
These will act as entry-point for ModuleTreeLinker implementation, which will
be introduced in a subsequent CL.

BUG=594639
Review-Url: https://codereview.chromium.org/2816413002
Cr-Commit-Position: refs/heads/master@{#465157}
Committed: https://chromium.googlesource.com/chromium/src/+/a43e1cb6e317fabdb886c7e743a081fbaaff1961

[kouhei (in TOK), 2017-04-17 05:53:03]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 05:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2017-04-17 05:53:28]

kouhei@chromium.org changed reviewers:
+ hiroshige@chromium.org, kinuko@chromium.org, yhirano@chromium.org

[commit-bot: I haz the power, 2017-04-17 07:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 07:29:37]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-04-18 00:48:42]

lgtm (if others are happy)

https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Modulator.h (right):

https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Modulator.h:81: ModuleTreeClient*) = 0;
This seems to be a substep of above (and the method name makes me feel
internal'ish), does this need to be at public layer?

https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Modulator.h:81: ModuleTreeClient*) = 0;
Ok, I found the callsite in the other CL for
#fetch-the-descendants-of-a-module-script

[kouhei (in TOK), 2017-04-18 00:53:18]

https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Modulator.h (right):

https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Modulator.h:81: ModuleTreeClient*) = 0;
On 2017/04/18 00:48:42, kinuko wrote:
> This seems to be a substep of above (and the method name makes me feel
> internal'ish), does this need to be at public layer?

I think this is a good question.
The only "public" API for modulator is probably FetchTree + ExecuteModule. The
other methods are for internal (core/dom/*Module*, core/loader/modulescript/*)
only.

I'd like to keep this as is for now, and revisit this issue once we have landed
majority of the code.

[hiroshige, 2017-04-18 01:58:12]

lgtm

[kouhei (in TOK), 2017-04-18 01:58:45]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-04-18 01:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 02:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:06:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kouhei (in TOK), 2017-04-18 04:08:56]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-04-18 04:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
hiroshige@chromium.org
Link to the patchset: https://codereview.chromium.org/2816413002/#ps20001
(title: "rebased platform/wtf")

[kouhei (in TOK), 2017-04-18 04:09:03]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:34:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492488543193420,
"parent_rev": "92d4a108882a01897d144d810bc22bcce20e9b46", "commit_rev":
"a43e1cb6e317fabdb886c7e743a081fbaaff1961"}

[commit-bot: I haz the power, 2017-04-18 06:34:27]

Description was changed from

==========
[ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single}

This CL introduces methods Modulator::Fetch{Tree,TreeInternal,Single}.
These will act as entry-point for ModuleTreeLinker implementation, which will
be introduced in a subsequent CL.

BUG=594639
==========

to

==========
[ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single}

This CL introduces methods Modulator::Fetch{Tree,TreeInternal,Single}.
These will act as entry-point for ModuleTreeLinker implementation, which will
be introduced in a subsequent CL.

BUG=594639

Review-Url: https://codereview.chromium.org/2816413002
Cr-Commit-Position: refs/heads/master@{#465157}
Committed:
https://chromium.googlesource.com/chromium/src/+/a43e1cb6e317fabdb886c7e743a0...
==========

[commit-bot: I haz the power, 2017-04-18 06:34:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a43e1cb6e317fabdb886c7e743a0...