Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2816413002: [ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single} (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
Reviewers:
kinuko, hiroshige, yhirano
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Introduce Modulator::Fetch{Tree,TreeInternal,Single} This CL introduces methods Modulator::Fetch{Tree,TreeInternal,Single}. These will act as entry-point for ModuleTreeLinker implementation, which will be introduced in a subsequent CL. BUG=594639 Review-Url: https://codereview.chromium.org/2816413002 Cr-Commit-Position: refs/heads/master@{#465157} Committed: https://chromium.googlesource.com/chromium/src/+/a43e1cb6e317fabdb886c7e743a081fbaaff1961

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebased platform/wtf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
A third_party/WebKit/Source/core/dom/AncestorList.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 3 chunks +26 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-17 05:53:29 UTC) #4
kinuko
lgtm (if others are happy) https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h File third_party/WebKit/Source/core/dom/Modulator.h (right): https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h#newcode81 third_party/WebKit/Source/core/dom/Modulator.h:81: ModuleTreeClient*) = 0; This ...
3 years, 8 months ago (2017-04-18 00:48:42 UTC) #7
kouhei (in TOK)
https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h File third_party/WebKit/Source/core/dom/Modulator.h (right): https://codereview.chromium.org/2816413002/diff/1/third_party/WebKit/Source/core/dom/Modulator.h#newcode81 third_party/WebKit/Source/core/dom/Modulator.h:81: ModuleTreeClient*) = 0; On 2017/04/18 00:48:42, kinuko wrote: > ...
3 years, 8 months ago (2017-04-18 00:53:18 UTC) #8
kouhei (in TOK)
3 years, 8 months ago (2017-04-18 00:53:19 UTC) #9
hiroshige
lgtm
3 years, 8 months ago (2017-04-18 01:58:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816413002/1
3 years, 8 months ago (2017-04-18 01:59:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/413331)
3 years, 8 months ago (2017-04-18 02:06:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816413002/20001
3 years, 8 months ago (2017-04-18 04:09:17 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 06:34:28 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a43e1cb6e317fabdb886c7e743a0...

Powered by Google App Engine
This is Rietveld 408576698