Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2816403004: Fire the `backgroundfetchfail` event for failed fetches (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire the `backgroundfetchfail` event for failed fetches Background Fetches that contain a failed request (e.g. 404) will now cause the `backgroundfetchfail` event to be fired as opposed to the `backgroundfetched` event. For now, inaccessible CORS requests will be considered as failures as well. BUG=692579 Review-Url: https://codereview.chromium.org/2816403004 Cr-Commit-Position: refs/heads/master@{#465262} Committed: https://chromium.googlesource.com/chromium/src/+/929fcfc0778b8848e9a4b2b5c205c1ae43cfa9f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -8 lines) Patch
M content/browser/background_fetch/background_fetch_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_context.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 4 chunks +100 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Peter Beverloo
+harkness
3 years, 8 months ago (2017-04-18 14:06:31 UTC) #3
harkness
lgtm
3 years, 8 months ago (2017-04-18 16:06:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816403004/1
3 years, 8 months ago (2017-04-18 16:27:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:31:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/929fcfc0778b8848e9a4b2b5c205...

Powered by Google App Engine
This is Rietveld 408576698