Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2816373003: Oilpan: Allow clearing a vector during pre finalizer to disallocate the backing buffer (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Allow clearing a vector during pre finalizer to disallocate the backing buffer Backing reallocation during pre finalizer is not allowed but allow disallocating of backing buffer. Also fixes mistake in PreFinalizerBackingShrinkForbidden::Dispose BUG=709201 Review-Url: https://codereview.chromium.org/2816373003 Cr-Commit-Position: refs/heads/master@{#464900} Committed: https://chromium.googlesource.com/chromium/src/+/784e352dc72da40651877527c97949c2370f9883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/Vector.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
keishi
PTAL
3 years, 8 months ago (2017-04-17 06:25:20 UTC) #7
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-17 06:28:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816373003/1
3 years, 8 months ago (2017-04-17 06:38:47 UTC) #11
haraken
LGTM
3 years, 8 months ago (2017-04-17 06:40:09 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 06:42:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/784e352dc72da40651877527c979...

Powered by Google App Engine
This is Rietveld 408576698