Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID, GetTemplateURLForHost

Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID, GetTemplateURLForHost

BUG=672364
Review-Url: https://codereview.chromium.org/2816353002
Cr-Commit-Position: refs/heads/master@{#465491}
Committed: https://chromium.googlesource.com/chromium/src/+/612137acaa5360d5f7d2e2ab5dbb20d0704405d7

[Peter Kasting, 2017-04-17 18:53:23]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2017-04-17 18:53:24]

LGTM

https://codereview.chromium.org/2816353002/diff/40001/components/search_engin...
File components/search_engines/template_url_service.cc (right):

https://codereview.chromium.org/2816353002/diff/40001/components/search_engin...
components/search_engines/template_url_service.cc:398: const base::string16&
keyword) const {
Nit: Definition order should match declaration order (
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
)

[jeffschiller, 2017-04-18 04:35:23]

Description was changed from

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364
==========

to

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364

eugenebut:
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
pkasting:
  chrome/browser/ui/omnibox/chrome_omnibox_client.cc
  chrome/browser/ui/omnibox/chrome_omnibox_client.h
  chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
  chrome/browser/ui/search_engines/edit_search_engine_controller.cc
  components/omnibox/browser/autocomplete_controller.cc
  components/omnibox/browser/autocomplete_match.cc
  components/omnibox/browser/base_search_provider.cc
  components/omnibox/browser/omnibox_client.cc
  components/omnibox/browser/omnibox_client.h
  components/search_engines/template_url_service.cc
  components/search_engines/template_url_service.h
dfalcantara:
  chrome/browser/android/locale/special_locale_handler.cc
==========

[jeffschiller, 2017-04-18 04:35:23]

jeffschiller@google.com changed reviewers:
+ dfalcantara@chromium.org, eugenebut@chromium.org

[jeffschiller, 2017-04-18 04:49:08]

On 2017/04/17 at 18:53:24, pkasting wrote:
> LGTM
> 
>
https://codereview.chromium.org/2816353002/diff/40001/components/search_engin...
> File components/search_engines/template_url_service.cc (right):
> 
>
https://codereview.chromium.org/2816353002/diff/40001/components/search_engin...
> components/search_engines/template_url_service.cc:398: const base::string16&
keyword) const {
> Nit: Definition order should match declaration order (
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
)

Done.

[jeffschiller, 2017-04-18 04:49:59]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 04:50:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-04-18 04:52:13]

Please edit the CL description to not have the reviewer list, and instead put
that list in the message you mail :)

[commit-bot: I haz the power, 2017-04-18 05:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 05:36:31]

Dry run: This issue passed the CQ dry run.

[jeffschiller, 2017-04-18 12:40:52]

Description was changed from

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364

eugenebut:
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
pkasting:
  chrome/browser/ui/omnibox/chrome_omnibox_client.cc
  chrome/browser/ui/omnibox/chrome_omnibox_client.h
  chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
  chrome/browser/ui/search_engines/edit_search_engine_controller.cc
  components/omnibox/browser/autocomplete_controller.cc
  components/omnibox/browser/autocomplete_match.cc
  components/omnibox/browser/base_search_provider.cc
  components/omnibox/browser/omnibox_client.cc
  components/omnibox/browser/omnibox_client.h
  components/search_engines/template_url_service.cc
  components/search_engines/template_url_service.h
dfalcantara:
  chrome/browser/android/locale/special_locale_handler.cc
==========

to

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364
==========

[jeffschiller, 2017-04-18 12:41:04]

eugenebut:
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h
  ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
pkasting:
  chrome/browser/ui/omnibox/chrome_omnibox_client.cc
  chrome/browser/ui/omnibox/chrome_omnibox_client.h
  chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
  chrome/browser/ui/search_engines/edit_search_engine_controller.cc
  components/omnibox/browser/autocomplete_controller.cc
  components/omnibox/browser/autocomplete_match.cc
  components/omnibox/browser/base_search_provider.cc
  components/omnibox/browser/omnibox_client.cc
  components/omnibox/browser/omnibox_client.h
  components/search_engines/template_url_service.cc
  components/search_engines/template_url_service.h
dfalcantara:
  chrome/browser/android/locale/special_locale_handler.cc

[Eugene But (OOO till 7-30), 2017-04-18 15:41:58]

ios lgtm

[gone, 2017-04-18 21:09:34]

special_locale_handler.cc lgtm

[jeffschiller, 2017-04-19 04:24:08]

The CQ bit was checked by jeffschiller@google.com

[jeffschiller, 2017-04-19 04:24:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2816353002/#ps60001
(title: "Make definition and declaration order of new functions match")

[commit-bot: I haz the power, 2017-04-19 04:24:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 04:34:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492575848441920,
"parent_rev": "c0abb68d248b76ecae92ad893db3886edd3aa59d", "commit_rev":
"612137acaa5360d5f7d2e2ab5dbb20d0704405d7"}

[commit-bot: I haz the power, 2017-04-19 04:35:01]

Description was changed from

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364
==========

to

==========
Make const versions GetTemplateURLForKeyword, GetTemplateURLForGUID,
GetTemplateURLForHost

BUG=672364

Review-Url: https://codereview.chromium.org/2816353002
Cr-Commit-Position: refs/heads/master@{#465491}
Committed:
https://chromium.googlesource.com/chromium/src/+/612137acaa5360d5f7d2e2ab5dbb...
==========

[commit-bot: I haz the power, 2017-04-19 04:35:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/612137acaa5360d5f7d2e2ab5dbb...