Treat cells with percent height as auto if their container depends on content height
After some clarification with the css-tables spec author and the CSSWG, only
treat cells as having a height that percent values can resolve against if the cell
has an explicitly specified height. For example, if the cell has a percent height
but nothing in its container chain to resolve that percentage against it doesn't
have an explicitly specified height.
BUG=687551
Review-Url: https://codereview.chromium.org/2816313002
Cr-Commit-Position: refs/heads/master@{#466287}
Committed: https://chromium.googlesource.com/chromium/src/+/019c92b5d6c58f4c240ea2b64bb748c9bb3a6c15
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/363372)
3 years, 8 months ago
(2017-04-15 18:40:24 UTC)
#4
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/423357)
3 years, 8 months ago
(2017-04-16 11:31:22 UTC)
#8
3 years, 8 months ago
(2017-04-20 21:13:09 UTC)
#14
rhogan
Description was changed from ========== Treat cells with percent height as auto if their container ...
3 years, 8 months ago
(2017-04-20 21:16:55 UTC)
#15
Description was changed from
==========
Treat cells with percent height as auto if their container depends on content
height
BUG=687551
==========
to
==========
Treat cells with percent height as auto if their container depends on content
height
After some clarification with the css-tables spec author and the CSSWG, only
treat cells as having a height that percent values can resolve against if the
cell
has an explicitly specified height. For example, if the cell has a percent
height
but nothing in its container chain to resolve that percentage against it doesn't
have an explicitly specified height.
BUG=687551
==========
eae
LGTM
3 years, 8 months ago
(2017-04-20 22:58:37 UTC)
#16
LGTM
rhogan
The CQ bit was checked by robhogan@gmail.com
3 years, 8 months ago
(2017-04-21 06:29:40 UTC)
#17
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492756180108390, "parent_rev": "7fd3f6718896969f1a5d3850a6d81f4ccf74abd3", "commit_rev": "019c92b5d6c58f4c240ea2b64bb748c9bb3a6c15"}
3 years, 8 months ago
(2017-04-21 08:03:42 UTC)
#19
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492756180108390,
"parent_rev": "7fd3f6718896969f1a5d3850a6d81f4ccf74abd3", "commit_rev":
"019c92b5d6c58f4c240ea2b64bb748c9bb3a6c15"}
commit-bot: I haz the power
Description was changed from ========== Treat cells with percent height as auto if their container ...
3 years, 8 months ago
(2017-04-21 08:03:53 UTC)
#20
Message was sent while issue was closed.
Description was changed from
==========
Treat cells with percent height as auto if their container depends on content
height
After some clarification with the css-tables spec author and the CSSWG, only
treat cells as having a height that percent values can resolve against if the
cell
has an explicitly specified height. For example, if the cell has a percent
height
but nothing in its container chain to resolve that percentage against it doesn't
have an explicitly specified height.
BUG=687551
==========
to
==========
Treat cells with percent height as auto if their container depends on content
height
After some clarification with the css-tables spec author and the CSSWG, only
treat cells as having a height that percent values can resolve against if the
cell
has an explicitly specified height. For example, if the cell has a percent
height
but nothing in its container chain to resolve that percentage against it doesn't
have an explicitly specified height.
BUG=687551
Review-Url: https://codereview.chromium.org/2816313002
Cr-Commit-Position: refs/heads/master@{#466287}
Committed:
https://chromium.googlesource.com/chromium/src/+/019c92b5d6c58f4c240ea2b64bb7...
==========
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/019c92b5d6c58f4c240ea2b64bb748c9bb3a6c15
3 years, 8 months ago
(2017-04-21 08:03:54 UTC)
#21
Issue 2816313002: Treat cells with percent height as auto if their container depends on content height
(Closed)
Created 3 years, 8 months ago by rhogan
Modified 3 years, 8 months ago
Reviewers: eae
Base URL:
Comments: 0