Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2816313002: Treat cells with percent height as auto if their container depends on content height (Closed)

Created:
3 years, 8 months ago by rhogan
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat cells with percent height as auto if their container depends on content height After some clarification with the css-tables spec author and the CSSWG, only treat cells as having a height that percent values can resolve against if the cell has an explicitly specified height. For example, if the cell has a percent height but nothing in its container chain to resolve that percentage against it doesn't have an explicitly specified height. BUG=687551 Review-Url: https://codereview.chromium.org/2816313002 Cr-Commit-Position: refs/heads/master@{#466287} Committed: https://chromium.googlesource.com/chromium/src/+/019c92b5d6c58f4c240ea2b64bb748c9bb3a6c15

Patch Set 1 #

Patch Set 2 : bug 687551 #

Patch Set 3 : bug 687551 #

Patch Set 4 : bug 687551 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row.html View 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 2 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
rhogan
3 years, 8 months ago (2017-04-20 21:13:09 UTC) #14
eae
LGTM
3 years, 8 months ago (2017-04-20 22:58:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816313002/60001
3 years, 8 months ago (2017-04-21 06:29:51 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 08:03:54 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/019c92b5d6c58f4c240ea2b64bb7...

Powered by Google App Engine
This is Rietveld 408576698