Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2816273002:
Implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility (Closed)
|
Created:
3 years, 8 months ago by dougt Modified:
3 years, 8 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility
BUG=703369
Review-Url: https://codereview.chromium.org/2816273002
Cr-Commit-Position: refs/heads/master@{#466552}
Committed: https://chromium.googlesource.com/chromium/src/+/0c9b90603321c436e6f892be5435fed84eff857a
Patch Set 1 #Patch Set 2 : stray semi #
Total comments: 1
Patch Set 3 : comment nit #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility BUG= ========== to ========== Implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility BUG=703369 ==========
dougt@chromium.org changed reviewers: + dmazzoni@chromium.org
ptal. this uses the non-internal form of the getters to implement the delegate.
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2816273002/diff/20001/content/browser/accessi... File content/browser/accessibility/browser_accessibility.cc (right): https://codereview.chromium.org/2816273002/diff/20001/content/browser/accessi... content/browser/accessibility/browser_accessibility.cc:1137: // AXPlatformNodeDelegate. nit: make this a larger block comment like we have in browser_accessibility_win: // // AXPlatformNodeDelegate. //
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dougt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2816273002/#ps40001 (title: "comment nit")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492895904662150,
"parent_rev": "e0a99ba807c98cb277234bb9ea557549bbf91aa8", "commit_rev":
"0c9b90603321c436e6f892be5435fed84eff857a"}
Message was sent while issue was closed.
Description was changed from ========== Implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility BUG=703369 ========== to ========== Implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility BUG=703369 Review-Url: https://codereview.chromium.org/2816273002 Cr-Commit-Position: refs/heads/master@{#466552} Committed: https://chromium.googlesource.com/chromium/src/+/0c9b90603321c436e6f892be5435... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0c9b90603321c436e6f892be5435... |
