Remove usage of Tab's |url| property from ShareToDataBuilder.

ios/chrome/browser/ui/activity_services/share_to_data_builder.mm

Index: ios/chrome/browser/ui/activity_services/share_to_data_builder.mm
diff --git a/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm b/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm
index 3fca21182a26e63ff6fb668deff7fa5c3611d9d4..f35d9967bbb8a730cb3a6a64bbcfa2725481ba7f 100644
--- a/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm
+++ b/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm
@@ -31,7 +31,7 @@
   BOOL isPagePrintable = [tab viewForPrinting] != nil;
   ThumbnailGeneratorBlock thumbnailGenerator =
       activity_services::ThumbnailGeneratorForTab(tab);
-  return [[ShareToData alloc] initWithURL:tab.url
+  return [[ShareToData alloc] initWithURL:tab.visibleURL

[rohitrao (ping after 24h), 2017/08/15 15:24:39]

I was looking at this code today and it seems weird that we use the URL from the
visible item, but the title from the lastCommittedItem.

This inconsistency is bad, right?

[Eugene But (OOO till 7-30), 2017/08/15 17:12:33]

Good catch. tab.title will always be the title of the currently rendered page.
tab.visibleURL can be a URL of the pending page.

[kkhorimoto (Do not use), 2017/08/15 17:53:16]

Since we agreed that it's most likely that the user's intent is to share the
visible URL, does it make sense to use GetTitleForDisplay() on the visible
NavigationItem?

                                     title:tab.title
                           isOriginalTitle:(tab.originalTitle != nil)
                           isPagePrintable:isPagePrintable