Remove usage of Tab's |url| property from ShareToDataBuilder.

ios/chrome/browser/ui/activity_services/share_to_data_builder.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/ui/activity_services/share_to_data_builder.h"
 
 #include "base/logging.h"
 #include "ios/chrome/browser/tabs/tab.h"
 #include "ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.h"
 #include "ios/chrome/browser/ui/activity_services/share_to_data.h"
@@ skipping 13 matching lines @@
   if (!tab.webState)
     return nil;
   DCHECK(tab);
   // If the original page title exists, it is expected to match the tab title.
   // If this ever changes, then a decision has to be made on which one should
   // be used for sharing.
   DCHECK(!tab.originalTitle || [tab.originalTitle isEqualToString:tab.title]);
   BOOL isPagePrintable = [tab viewForPrinting] != nil;
   ThumbnailGeneratorBlock thumbnailGenerator =
       activity_services::ThumbnailGeneratorForTab(tab);
-  return [[ShareToData alloc] initWithURL:tab.url
+  return [[ShareToData alloc] initWithURL:tab.visibleURL

[rohitrao (ping after 24h), 2017/08/15 15:24:39]

I was looking at this code today and it seems weird that we use the URL from the
visible item, but the title from the lastCommittedItem.

This inconsistency is bad, right?

[Eugene But (OOO till 7-30), 2017/08/15 17:12:33]

Good catch. tab.title will always be the title of the currently rendered page.
tab.visibleURL can be a URL of the pending page.

[kkhorimoto (Do not use), 2017/08/15 17:53:16]

Since we agreed that it's most likely that the user's intent is to share the
visible URL, does it make sense to use GetTitleForDisplay() on the visible
NavigationItem?

                                     title:tab.title
                           isOriginalTitle:(tab.originalTitle != nil)
                           isPagePrintable:isPagePrintable
                        thumbnailGenerator:thumbnailGenerator];
 }
 
 }  // namespace activity_services