Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

Issue 2816143003: bindings: Place bool flags in a batch in IDL dictionary (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
index 7c904e5ee5aa9c3dc082d67b0eee68e536e19eed..72a584577a832c5dc33e0b4f014dfc8800583a2d 100644
--- a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl
@@ -36,10 +36,10 @@ class {{exported}}{{cpp_class}}{% if parent_cpp_class %} : public {{parent_cpp_c
DECLARE_VIRTUAL_TRACE();
private:
- {% for member in members %}
- {% if member.nullable_indicator_name %}
+ {% for member in members if member.nullable_indicator_name %}
bool {{member.nullable_indicator_name}} = false;
- {% endif %}
+ {% endfor %}
+ {% for member in members %}
peria 2017/04/14 03:20:04 nit: would you put an empty line between two {% fo
bashi 2017/04/14 03:22:47 Hmm, actually I did that but reverted because it p
peria 2017/04/14 03:44:49 IMO, such empty lines should be removed in the fil
bashi 2017/04/14 03:55:28 I'd prefer not having an empty line but either is
{{member.member_cpp_type}} m_{{member.cpp_name}};
{% endfor %}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698