[WebPayments] Desktop implementation of Contact Editor

[WebPayments] Desktop implementation of Contact Editor

BUG=709535
Review-Url: https://codereview.chromium.org/2816083002
Cr-Commit-Position: refs/heads/master@{#466662}
Committed: https://chromium.googlesource.com/chromium/src/+/27028d78159cff5447dd3f98c5da756c91c65658

[tmartino, 2017-04-13 20:20:38]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-04-13 20:21:20]

tmartino@chromium.org changed reviewers:
+ mathp@chromium.org, sebsg@chromium.org

[tmartino, 2017-04-13 20:34:46]

tmartino@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:37:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-04-13 20:49:58]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 21:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:05:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-04-17 02:50:10]

Thanks Tommy, love this very meticulous work. Small comments from me

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
(right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:45:
EditorField::LengthHint::HINT_LONG, /* required= */ true));
very nit: I started preferring /*required=*/true so that it stays one big token.

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:72: //
TODO(tmartino): Move this method and its helpers to a base class shared
Since the code is getting pretty mature, we should file bugs to keep track of
TODOs (also easier to assign to people that want to help)

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:101:
return std::unique_ptr<ui::ComboboxModel>(nullptr);
nit: I wonder if "return nullptr;" also works here.

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:108:
IDS_PAYMENTS_ADD_CONTACT_DETAILS_LABEL);
Cool, I filed crbug.com/712074 for so that the other two editors do this :)
Thanks

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:114:
field.first->OnBlur();
interesting, I thought when this was called it was because of a click on "save"
which would have blurred the last focused field, but I guess we also need to
blur the other ones that have been pre-filled? Is this a bug in the other
editors? If so, let's file a bug/fix it!

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:126:
field.first->text(), locale);
nit: can inline state()->GetApplicationLocale() without too much ugliness

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
(right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:15:
#include "ui/base/models/simple_combobox_model.h"
does it work without this line? normally editor_view_controller should provide
this

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:19: }
}  // namespace autofill

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:25: //
Does not take ownership of the arguments, which should outlive this object.
Mention that |profile| can be nullptr but not the others

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:49: void
PopulateProfile(autofill::AutofillProfile* profile);
A comment would be good to explain populating what from what

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:67:
EditorViewController* controller_;
outlives this class, never null, etc.

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:68:
std::string locale_;
can keep const std::string& to avoid the copy

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog_view.cc (right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog_view.cc:257:
observer_for_testing_->OnContactInfoEditorOpened();
testing observer but no test file is included. Did you forget to add to CL?

https://codereview.chromium.org/2816083002/diff/40001/components/payments_str...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2816083002/diff/40001/components/payments_str...
components/payments_strings.grdp:10: <message
name="IDS_PAYMENTS_PHONE_FIELD_IN_CONTACT_DETAILS" desc="The label for text
input field containing a phone number. [CHAR-LIMIT=32]"
formatter_data="android_java">
let's remove formatted_data="android" if not used on Android

[tmartino, 2017-04-17 18:29:37]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:40:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tmartino, 2017-04-18 14:37:45]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 14:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-04-18 14:38:22]

LGTM, from my very minimal knowledge of UI stuff :)

[commit-bot: I haz the power, 2017-04-18 14:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 14:48:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[sebsg, 2017-04-18 15:44:33]

Added a question/comment

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
(right):

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:153:
autofill::AutofillCountry::CountryCodeForLocale(locale_);
Do you think we could use the country of the profile and/or check the country
field for this?

[anthonyvd, 2017-04-18 15:55:43]

lgtm with a few questions.

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
(right):

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:42: if
(spec()->request_payer_name()) {
Quick question: shouldn't we still display those fields even if the website
doesn't request them but mark them as not required?

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:115:
field.first->OnBlur();
Should we change the base so that this isn't required?

[tmartino, 2017-04-18 18:28:08]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:28:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-04-18 19:39:18]

Finally solved the weird build issue that was breaking tryjobs on old patchsets.
The changes to resource_ids will land in another CL and be rebased in here
before landing.

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
(right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:45:
EditorField::LengthHint::HINT_LONG, /* required= */ true));
On 2017/04/17 at 02:50:09, Mathieu wrote:
> very nit: I started preferring /*required=*/true so that it stays one big
token.

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:72: //
TODO(tmartino): Move this method and its helpers to a base class shared
On 2017/04/17 at 02:50:09, Mathieu wrote:
> Since the code is getting pretty mature, we should file bugs to keep track of
TODOs (also easier to assign to people that want to help)

crbug.com/712224

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:101:
return std::unique_ptr<ui::ComboboxModel>(nullptr);
On 2017/04/17 at 02:50:09, Mathieu wrote:
> nit: I wonder if "return nullptr;" also works here.

Yup! Done.

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:114:
field.first->OnBlur();
On 2017/04/17 at 02:50:09, Mathieu wrote:
> interesting, I thought when this was called it was because of a click on
"save" which would have blurred the last focused field, but I guess we also need
to blur the other ones that have been pre-filled? Is this a bug in the other
editors? If so, let's file a bug/fix it!

I got this behavior from the Shipping Address Editor, so it's at least fine
there:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/shippin...

We only start validating each field once it has been blurred once. (That way we
don't immediately show an error as soon as the user interacts with a field.) If
a field is pre-filled wrong, or more likely empty and never interacted with, we
need to blur so that we see a message.

I just tested and this doesn't work on credit card editor, so I filed
crbug.com/712236

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:126:
field.first->text(), locale);
On 2017/04/17 at 02:50:09, Mathieu wrote:
> nit: can inline state()->GetApplicationLocale() without too much ugliness

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
(right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:15:
#include "ui/base/models/simple_combobox_model.h"
On 2017/04/17 at 02:50:10, Mathieu wrote:
> does it work without this line? normally editor_view_controller should provide
this

We do need it in the .cc, but editor_view_controller gives us what we need for
the header. I moved this to the .cc

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:19: }
On 2017/04/17 at 02:50:09, Mathieu wrote:
> }  // namespace autofill

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:25: //
Does not take ownership of the arguments, which should outlive this object.
On 2017/04/17 at 02:50:09, Mathieu wrote:
> Mention that |profile| can be nullptr but not the others

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:49: void
PopulateProfile(autofill::AutofillProfile* profile);
On 2017/04/17 at 02:50:09, Mathieu wrote:
> A comment would be good to explain populating what from what

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:67:
EditorViewController* controller_;
On 2017/04/17 at 02:50:09, Mathieu wrote:
> outlives this class, never null, etc.

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.h:68:
std::string locale_;
On 2017/04/17 at 02:50:10, Mathieu wrote:
> can keep const std::string& to avoid the copy

Done

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog_view.cc (right):

https://codereview.chromium.org/2816083002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog_view.cc:257:
observer_for_testing_->OnContactInfoEditorOpened();
On 2017/04/17 at 02:50:10, Mathieu wrote:
> testing observer but no test file is included. Did you forget to add to CL?

I'm writing them now. Haven't decided whether to wait on submitting this CL or
just break it off into a separate one, but I wanted to get the groundwork in
place.

https://codereview.chromium.org/2816083002/diff/40001/components/payments_str...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2816083002/diff/40001/components/payments_str...
components/payments_strings.grdp:10: <message
name="IDS_PAYMENTS_PHONE_FIELD_IN_CONTACT_DETAILS" desc="The label for text
input field containing a phone number. [CHAR-LIMIT=32]"
formatter_data="android_java">
On 2017/04/17 at 02:50:10, Mathieu wrote:
> let's remove formatted_data="android" if not used on Android

Done

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
(right):

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:42: if
(spec()->request_payer_name()) {
On 2017/04/18 at 15:55:43, anthonyvd wrote:
> Quick question: shouldn't we still display those fields even if the website
doesn't request them but mark them as not required?

I'm not sure. From a data perspective it's nice, but from a UX perspective it
feels wrong to ask the user for information that wasn't shown in the list on the
prior screen.

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:115:
field.first->OnBlur();
On 2017/04/18 at 15:55:43, anthonyvd wrote:
> Should we change the base so that this isn't required?

Added a comment to crbug.com/712224 which deals with base class changes
following this CL.

https://codereview.chromium.org/2816083002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc:153:
autofill::AutofillCountry::CountryCodeForLocale(locale_);
On 2017/04/18 at 15:44:33, sebsg wrote:
> Do you think we could use the country of the profile and/or check the country
field for this?

Resolved offline

[commit-bot: I haz the power, 2017-04-18 19:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:40:03]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-04-18 20:47:02]

Thanks, would love to see tests alongside the code.

[tmartino, 2017-04-19 22:37:56]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:38:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:42:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tmartino, 2017-04-19 22:44:12]

Added tests!

I'm on my way out the door so I'll fix the patch failure in the morning. It's
trivial and shouldn't affect the rest of the CL.

[tmartino, 2017-04-20 15:15:33]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 15:15:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 16:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:04:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-04-20 17:49:42]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 17:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-04-20 17:51:22]

There were some changes to the State class (becoming more strict about not
showing if available payment methods aren't supported) that broke the new tests.
I updated the relevant JS file and the tests are passing locally now.

[tmartino, 2017-04-20 19:40:09]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 19:40:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:24:25]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-04-24 12:13:59]

Very cool Tommy! lgtm with 2 nits

https://codereview.chromium.org/2816083002/diff/180001/chrome/browser/ui/view...
File
chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
(right):

https://codereview.chromium.org/2816083002/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc:137:
base::RunLoop populate_data_loop;
I think you don't need 137-141 because we have AddAutofillProfile in
PaymentRequestBrowserTestBase

https://codereview.chromium.org/2816083002/diff/180001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc:151:
// Do not set name: This should have been populated when opening the screen.
Use PaymentRequestBrowserTestBase::GetEditorTextfieldValue to confirm name is
set

[tmartino, 2017-04-24 14:48:10]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 14:48:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 14:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 14:52:43]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-04-24 15:35:26]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 15:35:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:44:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:44:11]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-04-24 16:51:18]

The CQ bit was checked by tmartino@chromium.org

[tmartino, 2017-04-24 16:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org,
anthonyvd@chromium.org, mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2816083002/#ps220001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-24 16:51:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:56:40]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1493052678922600,
"parent_rev": "f120a871d23619bd90c973bc25b0007ab834c0c1", "commit_rev":
"27028d78159cff5447dd3f98c5da756c91c65658"}

[commit-bot: I haz the power, 2017-04-24 16:56:52]

Description was changed from

==========
[WebPayments] Desktop implementation of Contact Editor

BUG=709535
==========

to

==========
[WebPayments] Desktop implementation of Contact Editor

BUG=709535

Review-Url: https://codereview.chromium.org/2816083002
Cr-Commit-Position: refs/heads/master@{#466662}
Committed:
https://chromium.googlesource.com/chromium/src/+/27028d78159cff5447dd3f98c5da...
==========

[commit-bot: I haz the power, 2017-04-24 16:56:54]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/27028d78159cff5447dd3f98c5da...