Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2816073002: Remove dependency to ScriptFunction from DOMWrapperWorld (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency to ScriptFunction from DOMWrapperWorld This CL removes a dependency to ScriptFunction from DOMWrapperWorld by moving the definition of DOMWrapperWorld::RegisterDOMObjectHolder back inside the header file (removing the need to explicitly instantiate the template method). BUG=682322 Review-Url: https://codereview.chromium.org/2816073002 Cr-Commit-Position: refs/heads/master@{#465281} Committed: https://chromium.googlesource.com/chromium/src/+/acae20ba354fd3710f53934fb3e959ff2547661e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change callback type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -48 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 1 1 chunk +42 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 1 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
adithyas
3 years, 8 months ago (2017-04-13 20:48:55 UTC) #5
haraken
LGTM
3 years, 8 months ago (2017-04-13 22:54:20 UTC) #8
jbroman
lgtm https://codereview.chromium.org/2816073002/diff/1/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h (right): https://codereview.chromium.org/2816073002/diff/1/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h#newcode156 third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h:156: void (*callback)(const v8::WeakCallbackInfo<DOMObjectHolderBase>&)) { super-nit: V8 provides a ...
3 years, 8 months ago (2017-04-18 15:26:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816073002/20001
3 years, 8 months ago (2017-04-18 15:40:05 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 17:37:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acae20ba354fd3710f53934fb3e9...

Powered by Google App Engine
This is Rietveld 408576698