Remove dependency to ScriptFunction from DOMWrapperWorld

Remove dependency to ScriptFunction from DOMWrapperWorld

This CL removes a dependency to ScriptFunction from DOMWrapperWorld by moving the definition of DOMWrapperWorld::RegisterDOMObjectHolder back inside the header file (removing the need to explicitly instantiate the template method).

BUG=682322
Review-Url: https://codereview.chromium.org/2816073002
Cr-Commit-Position: refs/heads/master@{#465281}
Committed: https://chromium.googlesource.com/chromium/src/+/acae20ba354fd3710f53934fb3e959ff2547661e

[adithyas, 2017-04-13 19:30:17]

Description was changed from

==========
Remove dependency to ScriptFunction from DOMWrapperWorld

BUG=682322
==========

to

==========
Remove dependency to ScriptFunction from DOMWrapperWorld

This CL removes a dependency to ScriptFunction from DOMWrapperWorld by moving
the definition of DOMWrapperWorld::RegisterDOMObjectHolder back inside the
header file (removing the need to explicitly instantiate the template method).

BUG=682322
==========

[adithyas, 2017-04-13 19:30:27]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:30:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-04-13 20:48:54]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:28:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-04-13 22:54:20]

LGTM

[jbroman, 2017-04-18 15:26:03]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-04-18 15:26:03]

lgtm

https://codereview.chromium.org/2816073002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h (right):

https://codereview.chromium.org/2816073002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h:156: void
(*callback)(const v8::WeakCallbackInfo<DOMObjectHolderBase>&)) {
super-nit: V8 provides a type alias that makes this line slightly shorter:

void SetWeak(v8::WeakCallbackInfo<DOMObjectHolderBase>::Callback callback) {

(not required, since it was already this way, but hey :P)

[adithyas, 2017-04-18 15:39:12]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-18 15:39:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2816073002/#ps20001
(title: "Change callback type")

[commit-bot: I haz the power, 2017-04-18 15:40:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 17:37:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492529952342280,
"parent_rev": "1361d4b18439259e34712495ad154cdff1d548a7", "commit_rev":
"acae20ba354fd3710f53934fb3e959ff2547661e"}

[commit-bot: I haz the power, 2017-04-18 17:37:18]

Description was changed from

==========
Remove dependency to ScriptFunction from DOMWrapperWorld

This CL removes a dependency to ScriptFunction from DOMWrapperWorld by moving
the definition of DOMWrapperWorld::RegisterDOMObjectHolder back inside the
header file (removing the need to explicitly instantiate the template method).

BUG=682322
==========

to

==========
Remove dependency to ScriptFunction from DOMWrapperWorld

This CL removes a dependency to ScriptFunction from DOMWrapperWorld by moving
the definition of DOMWrapperWorld::RegisterDOMObjectHolder back inside the
header file (removing the need to explicitly instantiate the template method).

BUG=682322

Review-Url: https://codereview.chromium.org/2816073002
Cr-Commit-Position: refs/heads/master@{#465281}
Committed:
https://chromium.googlesource.com/chromium/src/+/acae20ba354fd3710f53934fb3e9...
==========

[commit-bot: I haz the power, 2017-04-18 17:37:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acae20ba354fd3710f53934fb3e9...