cc/trees/layer_tree_host.cc - Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)

Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host.cc

diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc

index e8a6f4b0c072b22299d482b4ef601d92066b1dd1..6cc84cd292367dd610e134357beb8f716039aa53 100644

--- a/cc/trees/layer_tree_host.cc

+++ b/cc/trees/layer_tree_host.cc

@@ -788,7 +788,7 @@ void LayerTreeHost::ApplyScrollAndScale(ScrollAndScaleSet* info) {

SetNeedsUpdateLayers();

}

for (size_t i = 0; i < info->scrollbars.size(); ++i) {

- Layer* layer = LayerById(info->scrollbars[i].layer_id);

+ Layer* layer = LayerByElementId(info->scrollbars[i].element_id);

if (!layer)

continue;

layer->SetScrollbarsHiddenFromImplSide(info->scrollbars[i].hidden);