Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: cc/trees/layer_tree_host.cc

Issue 2816063003: Replace layer id with Element id for tracking scrollbar animation controllers (Closed)
Patch Set: Address reviewer comments, pull element_id.h change to another patch Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host.h" 5 #include "cc/trees/layer_tree_host.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 if (root_layer_) { 781 if (root_layer_) {
782 for (size_t i = 0; i < info->scrolls.size(); ++i) { 782 for (size_t i = 0; i < info->scrolls.size(); ++i) {
783 Layer* layer = LayerById(info->scrolls[i].layer_id); 783 Layer* layer = LayerById(info->scrolls[i].layer_id);
784 if (!layer) 784 if (!layer)
785 continue; 785 continue;
786 layer->SetScrollOffsetFromImplSide(gfx::ScrollOffsetWithDelta( 786 layer->SetScrollOffsetFromImplSide(gfx::ScrollOffsetWithDelta(
787 layer->scroll_offset(), info->scrolls[i].scroll_delta)); 787 layer->scroll_offset(), info->scrolls[i].scroll_delta));
788 SetNeedsUpdateLayers(); 788 SetNeedsUpdateLayers();
789 } 789 }
790 for (size_t i = 0; i < info->scrollbars.size(); ++i) { 790 for (size_t i = 0; i < info->scrollbars.size(); ++i) {
791 Layer* layer = LayerById(info->scrollbars[i].layer_id); 791 Layer* layer = LayerByElementId(info->scrollbars[i].element_id);
792 if (!layer) 792 if (!layer)
793 continue; 793 continue;
794 layer->SetScrollbarsHiddenFromImplSide(info->scrollbars[i].hidden); 794 layer->SetScrollbarsHiddenFromImplSide(info->scrollbars[i].hidden);
795 } 795 }
796 } 796 }
797 797
798 // This needs to happen after scroll deltas have been sent to prevent top 798 // This needs to happen after scroll deltas have been sent to prevent top
799 // controls from clamping the layout viewport both on the compositor and 799 // controls from clamping the layout viewport both on the compositor and
800 // on the main thread. 800 // on the main thread.
801 ApplyViewportDeltas(info); 801 ApplyViewportDeltas(info);
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 LayerListReverseIterator<Layer> LayerTreeHost::rend() { 1435 LayerListReverseIterator<Layer> LayerTreeHost::rend() {
1436 return LayerListReverseIterator<Layer>(nullptr); 1436 return LayerListReverseIterator<Layer>(nullptr);
1437 } 1437 }
1438 1438
1439 void LayerTreeHost::SetNeedsDisplayOnAllLayers() { 1439 void LayerTreeHost::SetNeedsDisplayOnAllLayers() {
1440 for (auto* layer : *this) 1440 for (auto* layer : *this)
1441 layer->SetNeedsDisplay(); 1441 layer->SetNeedsDisplay();
1442 } 1442 }
1443 1443
1444 } // namespace cc 1444 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698