Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

BUG=696223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2816033004
Cr-Commit-Position: refs/heads/master@{#467007}
Committed: https://chromium.googlesource.com/chromium/src/+/05b481280cf7cedb90c986f4b46aaaf87e781eca

[xlai (Olivia), 2017-04-13 17:31:23]

Description was changed from

==========
Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

BUG=696223
==========

to

==========
Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

BUG=696223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Justin Novosad, 2017-04-13 17:37:43]

junov@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-04-13 17:37:43]

https://codereview.chromium.org/2816033004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap-texImage2D.html
(right):

https://codereview.chromium.org/2816033004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap-texImage2D.html:45:
var gl = canvas2d.getContext('webgl');
weird that this one is called canvas2d

[xlai (Olivia), 2017-04-18 15:20:07]

xlai@chromium.org changed reviewers:
+ zmo@chromium.org

[xlai (Olivia), 2017-04-18 15:20:07]

zmo@chromium.org: Please review code changes. I remove the layout test in
PatchSet 1 because the layout test is not supporting webgl2. I will quickly
follow up with a transferToImageBitmap test in webgl conformance suite in
KhronoGroup.

[Zhenyao Mo, 2017-04-18 17:27:36]

On 2017/04/18 15:20:07, xlai (Olivia) wrote:
> mailto:zmo@chromium.org: Please review code changes. I remove the layout test
in
> PatchSet 1 because the layout test is not supporting webgl2. I will quickly
> follow up with a transferToImageBitmap test in webgl conformance suite in
> KhronoGroup.

LGTM

As I pointed out privately, it's better to add the test to github and roll it in
(with test suppressed), then land this one and un-suppress the test.

If you are very confident this works, since it's trivia, then just landing this
is fine also.

[xlai (Olivia), 2017-04-19 15:15:02]

On 2017/04/18 17:27:36, Zhenyao Mo wrote:
> On 2017/04/18 15:20:07, xlai (Olivia) wrote:
> > mailto:zmo@chromium.org: Please review code changes. I remove the layout
test
> in
> > PatchSet 1 because the layout test is not supporting webgl2. I will quickly
> > follow up with a transferToImageBitmap test in webgl conformance suite in
> > KhronoGroup.
> 
> LGTM
> 
> As I pointed out privately, it's better to add the test to github and roll it
in
> (with test suppressed), then land this one and un-suppress the test.
> 
> If you are very confident this works, since it's trivia, then just landing
this
> is fine also.

Yup I've sent the github pull request
(https://github.com/KhronosGroup/WebGL/pull/2374)
 for adding the test to you.

[xlai (Olivia), 2017-04-25 14:28:59]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:29:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 16:19:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493130539248760,
"parent_rev": "2581f79d9b179db1a42c5fb06e636a2467a784c9", "commit_rev":
"05b481280cf7cedb90c986f4b46aaaf87e781eca"}

[commit-bot: I haz the power, 2017-04-25 16:19:17]

Description was changed from

==========
Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

BUG=696223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.WebGL2Context TransferToImageBitmap

BUG=696223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2816033004
Cr-Commit-Position: refs/heads/master@{#467007}
Committed:
https://chromium.googlesource.com/chromium/src/+/05b481280cf7cedb90c986f4b46a...
==========

[commit-bot: I haz the power, 2017-04-25 16:19:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05b481280cf7cedb90c986f4b46a...