MD Settings: Internet: Proxy: Support partial proxies

MD Settings: Internet: Proxy: Support partial proxies

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815923002
Cr-Commit-Position: refs/heads/master@{#464320}
Committed: https://chromium.googlesource.com/chromium/src/+/8bc32204bc129658adab8e1fb8be3058c723e6ca

[stevenjb, 2017-04-12 17:41:37]

Description was changed from

==========
MD Settings: Internet: Proxy: Support partial proxies

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
==========

to

==========
MD Settings: Internet: Proxy: Support partial proxies

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-12 17:45:23]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-04-12 23:42:45]

Seems like a good point to make a common array for the proxy types and loop
through that to do all the property mungings. But that can happen later.

https://codereview.chromium.org/2815923002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy.js (right):

https://codereview.chromium.org/2815923002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.js:177: {Host: '',
Port: 80};
optional: make a helper function to make this object, or to do the whole
(getSimpleActiveProperties(foo) || {...}) thing

[michaelpg, 2017-04-12 23:42:50]

oh and, lgtm

[stevenjb, 2017-04-12 23:43:52]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:44:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:18:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-04-13 02:44:25]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:45:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 04:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 04:17:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-04-13 05:00:16]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-13 05:00:21]

The CQ bit was unchecked by stevenjb@chromium.org

[stevenjb, 2017-04-13 05:01:16]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-13 05:01:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2815923002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-13 05:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 06:24:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492059676687720,
"parent_rev": "286fb9be7c5d37cc6b234cfd333053b09a1106d4", "commit_rev":
"8bc32204bc129658adab8e1fb8be3058c723e6ca"}

[commit-bot: I haz the power, 2017-04-13 06:25:50]

Description was changed from

==========
MD Settings: Internet: Proxy: Support partial proxies

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Proxy: Support partial proxies

The MD Settings proxy implementation did not support
proxy configurations that did not include a HTTP proxy.
This is a bug, we should support, e.g., just setting a
FTP proxy.

BUG=708561
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815923002
Cr-Commit-Position: refs/heads/master@{#464320}
Committed:
https://chromium.googlesource.com/chromium/src/+/8bc32204bc129658adab8e1fb8be...
==========

[commit-bot: I haz the power, 2017-04-13 06:25:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8bc32204bc129658adab8e1fb8be...