Break circular dependency between InitializeDeviceDisablingManager and DeviceDisabledScreen

chrome/browser/chromeos/system/device_disabling_manager.h

Index: chrome/browser/chromeos/system/device_disabling_manager.h
diff --git a/chrome/browser/chromeos/system/device_disabling_manager.h b/chrome/browser/chromeos/system/device_disabling_manager.h
index c8e7ebaa7b27b3b0698cde3a7b2429ab84127a8d..8515b5aee057660b8c30a16d9566714fb3583b8c 100644
--- a/chrome/browser/chromeos/system/device_disabling_manager.h
+++ b/chrome/browser/chromeos/system/device_disabling_manager.h
@@ -88,6 +88,8 @@ class DeviceDisablingManager {
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
+  void Init();

[emaxx, 2017/04/13 13:57:31]

nit: Please add a comment like "Must be called after construction".

[emaxx, 2017/04/13 13:57:31]

nit: Move this method upper, right between constructors/destructors and the
following members. This would help to notice it.

[Ivan Šandrk, 2017/04/13 14:22:25]

Should I maybe create a factory method or something like
CreateDeviceDisablingManager, have that one construct the object and call Init()
on it, and then make the constructor and Init() private?

[emaxx, 2017/04/13 14:30:01]

But how will the bug resolved then? If you do all the initialization inside the
factory, then something will read nullptr from BrowserProcessPlatformPart during
the initialization.

[Ivan Šandrk, 2017/04/13 14:44:09]

Done.

[Ivan Šandrk, 2017/04/13 14:44:09]

Done.

[Ivan Šandrk, 2017/04/13 14:44:09]

Haha good point, forgot about that. Was too focused on one part of code xD

+
   // Returns the cached domain that owns the device. The domain is only
   // guaranteed to be up to date if the disabled screen was triggered.
   const std::string& enrollment_domain() const { return enrollment_domain_; }
@@ -107,8 +109,6 @@ class DeviceDisablingManager {
   static bool HonorDeviceDisablingDuringNormalOperation();
 
  private:
-  void Init();
-
   // Cache the disabled message and inform observers if it changed.
   void CacheDisabledMessageAndNotify(const std::string& disabled_message);