Break circular dependency between InitializeDeviceDisablingManager and DeviceDisabledScreen

chrome/browser/chromeos/login/screens/device_disabled_screen.cc

Index: chrome/browser/chromeos/login/screens/device_disabled_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/device_disabled_screen.cc b/chrome/browser/chromeos/login/screens/device_disabled_screen.cc
index 66d644c1c6fb0bf47631bf5d51a946636647962c..4ba8b71038b166ab35628b8ff50afb7be922c334 100644
--- a/chrome/browser/chromeos/login/screens/device_disabled_screen.cc
+++ b/chrome/browser/chromeos/login/screens/device_disabled_screen.cc
@@ -24,6 +24,7 @@ DeviceDisabledScreen::DeviceDisabledScreen(
   DCHECK(view_);
   if (view_)

[emaxx, 2017/04/13 13:57:31]

BTW, while you are here: this condition also contradicts our style guide for the
DCHECK's. The next line should be done unconditionally (letting it to crash or
whatever - we don't care assuming that the DCHECK is correct).

[Ivan Šandrk, 2017/04/13 14:44:09]

Done.

     view_->SetDelegate(this);
+  CHECK(device_disabling_manager_);

[emaxx, 2017/04/13 13:57:31]

nit: Use DCHECK here.
CHECK's, as explained in the style guide, should be only used in cases like
protecting against security vulnerabilities.

[Ivan Šandrk, 2017/04/13 14:22:25]

Was waiting on Achuith's response before changing it, but might as well change
it immediately :)

[Ivan Šandrk, 2017/04/13 14:44:09]

Done.

   device_disabling_manager_->AddObserver(this);
 }