Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2815873003: PPC/s390: [builtins] Change semantics of class constructors returning primitives (Closed)

Created:
3 years, 8 months ago by john.yan
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Change semantics of class constructors returning primitives Port a7c4e778466633d838c7f7d538da890853d5ea51 Original Commit Message: This change mirrors the semantics for derived class constructors. This change doesn't affect non class constructors. This change could potentially break web compat. More details: https://github.com/tc39/ecma262/pull/469 R=gsathya@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2815873003 Cr-Commit-Position: refs/heads/master@{#44627} Committed: https://chromium.googlesource.com/v8/v8/+/d9f6dd896ce92400699bb90a403894c9e5f94757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -22 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 8 chunks +32 lines, -11 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 8 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
john.yan
ptal
3 years, 8 months ago (2017-04-12 16:43:06 UTC) #1
JaideepBajwa
lgtm
3 years, 8 months ago (2017-04-12 16:57:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815873003/1
3 years, 8 months ago (2017-04-12 17:00:57 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-12 17:00:59 UTC) #6
JoranSiu
lgtm
3 years, 8 months ago (2017-04-12 19:43:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815873003/1
3 years, 8 months ago (2017-04-12 19:57:56 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:59:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d9f6dd896ce92400699bb90a403894c9e5f...

Powered by Google App Engine
This is Rietveld 408576698