Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: build/vs_toolchain.py

Issue 2815873002: Get Chrome compiling on VS2017 Community edition (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/vs_toolchain.py
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py
index 90a562d3fb67d17be366500ef264c5a588b0f67e..3e1fe449a48c0e7f7f25c0da11042f37c1429b50 100755
--- a/build/vs_toolchain.py
+++ b/build/vs_toolchain.py
@@ -154,6 +154,10 @@ def DetectVisualStudioPath():
path = os.environ.get('vs2017_install', path)
if os.path.exists(path):
return path
+ # Try MSVS 2017 Community edition.
+ path = r'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community'
+ if os.path.exists(path):
+ return path
else:
keys = [r'HKLM\Software\Microsoft\VisualStudio\%s' % version,
r'HKLM\Software\Wow6432Node\Microsoft\VisualStudio\%s' % version]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698