Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java

Issue 2815833003: [SmartText selection] Add LocaleList to the provider interface (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java
index 50890fea3708421a69ca6f40837a9a7fa6ee0848..4300e60b907b2e4dccbee7cb2c84f79edfc28690 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java
@@ -6,6 +6,7 @@ package org.chromium.content.browser;
import android.content.Intent;
import android.graphics.drawable.Drawable;
+import android.os.LocaleList;
Ted C 2017/04/13 17:17:10 LocaleList is api 24...are any of the apis below c
Tima Vaisburd 2017/04/13 18:11:32 The implementation only calls to TextClassifier AP
import android.view.View.OnClickListener;
import org.chromium.base.annotations.SuppressFBWarnings;
@@ -78,7 +79,8 @@ public interface ContextSelectionProvider {
* @param end The index pointing to the first character that comes after
* the selected text inside the textual context.
*/
- public void sendSuggestAndClassifyRequest(CharSequence text, int start, int end);
+ public void sendSuggestAndClassifyRequest(
+ CharSequence text, int start, int end, LocaleList locales);
/**
* Sends asynchronous request to obtain the selection and analyze its type.
@@ -87,7 +89,7 @@ public interface ContextSelectionProvider {
* @param end The index pointing to the first character that comes after
* the selected text inside the textual context.
*/
- public void sendClassifyRequest(CharSequence text, int start, int end);
+ public void sendClassifyRequest(CharSequence text, int start, int end, LocaleList locales);
/**
* Cancel all asynchronous requests.

Powered by Google App Engine
This is Rietveld 408576698