content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java - Issue 2815833003: [SmartText selection] Add LocaleList to the provider interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

Issue 2815833003: [SmartText selection] Add LocaleList to the provider interface (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContextSelectionProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

index 63d5a6161b39fcdec62b31c4f734ad5506b61ce6..6a8bcea1be127d6450024cd13c9400a3b5a49a39 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

@@ -137,11 +137,11 @@ public class ContextSelectionClient implements SelectionClient {

switch (callbackData) {

case SUGGEST_AND_CLASSIFY:

- mProvider.sendSuggestAndClassifyRequest(text, start, end);

+ mProvider.sendSuggestAndClassifyRequest(text, start, end, null);

boliu 2017/04/13 02:52:31 so this is not implemented yet?

break;

case CLASSIFY:

- mProvider.sendClassifyRequest(text, start, end);

+ mProvider.sendClassifyRequest(text, start, end, null);

break;

default: