Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2815783002: [MD settings] vertical align left edge of icons and text in ChromeOS People (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] vertical align left edge of icons and text in ChromeOS People This CL updates the vertical alignment of items on multiples of 60px (the old style was to line up on multiples of 56px). BUG=710704, 709654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815783002 Cr-Commit-Position: refs/heads/master@{#464096} Committed: https://chromium.googlesource.com/chromium/src/+/bc24ac56413d35a83928c20bb3ccb087086b4b44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M chrome/browser/resources/settings/people_page/user_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/users_page.html View 2 chunks +13 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dschuyler
3 years, 8 months ago (2017-04-12 01:09:09 UTC) #6
dschuyler
On 2017/04/12 01:09:09, dschuyler wrote: screen shot in bug.
3 years, 8 months ago (2017-04-12 01:09:31 UTC) #7
Dan Beam
lgtm
3 years, 8 months ago (2017-04-12 01:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815783002/1
3 years, 8 months ago (2017-04-12 18:27:09 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 18:50:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc24ac56413d35a83928c20bb3cc...

Powered by Google App Engine
This is Rietveld 408576698