Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2815773004: Fix update_histogram_enum.py when UpdateHistogramEnum is called. (Closed)

Created:
3 years, 8 months ago by Bret
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix update_histogram_enum.py when UpdateHistogramEnum is called. crrev.com/2797043002 updated the return value of ReadHistogramValues but missed some callsites. R=isherman@chromium.org, holte@chromium.org CC=lunalu@chromium.org Review-Url: https://codereview.chromium.org/2815773004 Cr-Commit-Position: refs/heads/master@{#464544} Committed: https://chromium.googlesource.com/chromium/src/+/3c4f4d8b07847c8612f7fa92ce36c032247ef42e

Patch Set 1 #

Patch Set 2 : another callsite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/metrics/histograms/update_histogram_enum.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/update_use_counter_feature_enum.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Bret
dpranke PTAL
3 years, 8 months ago (2017-04-12 23:18:08 UTC) #2
Dirk Pranke
I'm the wrong reviewer for this.Adding better reviewers ...
3 years, 8 months ago (2017-04-13 01:06:26 UTC) #6
Ilya Sherman
LGTM as a quick fix, but I have some concerns about the original CL, which ...
3 years, 8 months ago (2017-04-13 01:13:11 UTC) #7
lunalu1
Thanks for the comments. I will address the concerns in the original CL. On Wed, ...
3 years, 8 months ago (2017-04-13 18:05:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815773004/20001
3 years, 8 months ago (2017-04-13 20:46:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:03:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c4f4d8b07847c8612f7fa92ce36...

Powered by Google App Engine
This is Rietveld 408576698