Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2815773003: Make json5_generator.Writer always take a list of files. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make json5_generator.Writer always take a list of files. The json5_generator.Writer constructor has a convenient interface where you can specify either the name of a single file you want to read from, or a list of files. However, this requires a branch in Writer that checks if the argument is a string or a list, which is not Pythonic. This patch makes Writer always take a list of files. BUG=628043 Review-Url: https://codereview.chromium.org/2815773003 Cr-Commit-Position: refs/heads/master@{#466175} Committed: https://chromium.googlesource.com/chromium/src/+/3c3d810d9753f4c0138a84e0a4965880866304ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/build/scripts/json5_generator.py View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 33 (25 generated)
shend
Hi Bugs, PTAL
3 years, 8 months ago (2017-04-12 07:51:28 UTC) #2
Bugs Nash
lgtm
3 years, 8 months ago (2017-04-12 23:19:39 UTC) #7
shend
Hi Alan, PTAL
3 years, 8 months ago (2017-04-12 23:22:14 UTC) #9
alancutter (OOO until 2018)
https://codereview.chromium.org/2815773003/diff/1/third_party/WebKit/Source/build/scripts/json5_generator.py File third_party/WebKit/Source/build/scripts/json5_generator.py (left): https://codereview.chromium.org/2815773003/diff/1/third_party/WebKit/Source/build/scripts/json5_generator.py#oldcode200 third_party/WebKit/Source/build/scripts/json5_generator.py:200: json5_files = [json5_files] This code (that existed) smells bad. ...
3 years, 8 months ago (2017-04-13 03:23:52 UTC) #10
shend
Fixed, PTAL https://codereview.chromium.org/2815773003/diff/1/third_party/WebKit/Source/build/scripts/json5_generator.py File third_party/WebKit/Source/build/scripts/json5_generator.py (left): https://codereview.chromium.org/2815773003/diff/1/third_party/WebKit/Source/build/scripts/json5_generator.py#oldcode200 third_party/WebKit/Source/build/scripts/json5_generator.py:200: json5_files = [json5_files] On 2017/04/13 at 03:23:52, ...
3 years, 8 months ago (2017-04-13 03:57:43 UTC) #12
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-04-13 03:58:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815773003/60001
3 years, 8 months ago (2017-04-20 22:50:43 UTC) #30
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:56:01 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3c3d810d9753f4c0138a84e0a496...

Powered by Google App Engine
This is Rietveld 408576698