Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2815773002: Disable flaky showcase tests (Closed)

Created:
3 years, 8 months ago by liaoyuke
Modified:
3 years, 8 months ago
Reviewers:
edchin, lpromero
CC:
chromium-reviews, marq+watch_chromium.org, lpromero+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

disable flaky showcase tests Disabling following tests because they are flaky on devices (failed 5 times during the past 20 runs): SCTabTestCase/testLaunchWithTopToolbar SCTabTestCase/testLaunchWithBottomToolbar SCTabTestCase/testLaunchAndTappingCell TBR=lpromero@chromium.org BUG=710662 Review-Url: https://codereview.chromium.org/2815773002 Cr-Commit-Position: refs/heads/master@{#463831} Committed: https://chromium.googlesource.com/chromium/src/+/0a3ff882814b1367aa8397337e2696686816efd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ios/showcase/tab/sc_tab_egtest.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/showcase/tab_grid/sc_tab_grid_egtest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
liaoyuke
PTAL. Thank you very much!
3 years, 8 months ago (2017-04-11 23:09:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815773002/1
3 years, 8 months ago (2017-04-11 23:11:13 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 23:24:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a3ff882814b1367aa8397337e26...

Powered by Google App Engine
This is Rietveld 408576698