Move a couple of blob tests next to the files they cover.

Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2815743002
Cr-Commit-Position: refs/heads/master@{#464290}
Committed: https://chromium.googlesource.com/chromium/src/+/343665e7bad5f7f1b01b8bfec116cff4194766d8

[pwnall, 2017-04-11 20:18:28]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:19:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 20:24:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pwnall, 2017-04-11 22:12:26]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-04-11 22:13:43]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-11 22:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:18:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pwnall, 2017-04-11 22:19:58]

pwnall@chromium.org changed reviewers:
+ jsbell@chromium.org, kinuko@chromium.org

[pwnall, 2017-04-11 22:19:59]

kinuko: Can you please review the diffs? The count looks scary, but it's
actually a few file moves and ~200 lines changed across ~70 files.

jsbell: Can you please review adding a test_support target and test/ directory
to storage/browser? Is this approach reasonable?

[pwnall, 2017-04-11 22:24:25]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:25:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:30:25]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-04-12 03:00:23]

Looking good, one question- are you going to make namespace changes eventually?

[pwnall, 2017-04-12 03:05:19]

On 2017/04/12 03:00:23, kinuko wrote:
> Looking good, one question- are you going to make namespace changes
eventually?

I would like to have the namespaces changed as well. When I first scoped this
move, I did everything in one CL, and it was massive (~20k lines), so I've been
erring on the side of small steps.

Would you prefer that I change namespaces in this CL, or in a follow up? I can
go either way.

[kinuko, 2017-04-12 03:27:46]

On 2017/04/12 03:05:19, pwnall wrote:
> On 2017/04/12 03:00:23, kinuko wrote:
> > Looking good, one question- are you going to make namespace changes
> eventually?
> 
> I would like to have the namespaces changed as well. When I first scoped this
> move, I did everything in one CL, and it was massive (~20k lines), so I've
been
> erring on the side of small steps.
> 
> Would you prefer that I change namespaces in this CL, or in a follow up? I can
> go either way.

Nope, fine with landing that in smaller CLs. LGTM

[jsbell, 2017-04-13 00:46:15]

lgtm

[pwnall, 2017-04-13 00:52:00]

pwnall@chromium.org changed reviewers:
+ brettw@chromium.org

[pwnall, 2017-04-13 00:52:01]

brettw@chromium.org: Please review the changes in chrome/browser/ and
extensions/.

[Lei Zhang, 2017-04-13 01:05:23]

On 2017/04/13 00:52:01, pwnall wrote:
> mailto:brettw@chromium.org: Please review the changes in chrome/browser/ and
> extensions/.

You should just ask chrome/OWNERS + extensions/OWNERS. I can look over chrome/
if you can tell me what hasn't been covered by existing approvals.

[Lei Zhang, 2017-04-13 01:11:32]

On 2017/04/13 01:05:23, Lei Zhang wrote:
> On 2017/04/13 00:52:01, pwnall wrote:
> > mailto:brettw@chromium.org: Please review the changes in chrome/browser/ and
> > extensions/.
> 
> You should just ask chrome/OWNERS + extensions/OWNERS. I can look over chrome/
> if you can tell me what hasn't been covered by existing approvals.

chrome/ LGTM. I looked over extensions and I'd say just TBR an owner there.

[pwnall, 2017-04-13 01:16:02]

Description was changed from

==========
Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
==========

to

==========
Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin
==========

[pwnall, 2017-04-13 01:16:02]

pwnall@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thestig@chromium.org
- brettw@chromium.org

[pwnall, 2017-04-13 01:16:13]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-04-13 01:16:49]

On 2017/04/13 01:11:32, Lei Zhang wrote:
> On 2017/04/13 01:05:23, Lei Zhang wrote:
> > On 2017/04/13 00:52:01, pwnall wrote:
> > > mailto:brettw@chromium.org: Please review the changes in chrome/browser/
and
> > > extensions/.
> > 
> > You should just ask chrome/OWNERS + extensions/OWNERS. I can look over
chrome/
> > if you can tell me what hasn't been covered by existing approvals.
> 
> chrome/ LGTM. I looked over extensions and I'd say just TBR an owner there.

Done. Thank you very much for the advice!

[commit-bot: I haz the power, 2017-04-13 01:17:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:56:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:56:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pwnall, 2017-04-13 03:22:36]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:22:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 04:04:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492053756845630,
"parent_rev": "ecb2ad24952b077e71e56ba9d3edfc83c522f32a", "commit_rev":
"343665e7bad5f7f1b01b8bfec116cff4194766d8"}

[commit-bot: I haz the power, 2017-04-13 04:09:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492053756845630,
"parent_rev": "ecb2ad24952b077e71e56ba9d3edfc83c522f32a", "commit_rev":
"343665e7bad5f7f1b01b8bfec116cff4194766d8"}

[commit-bot: I haz the power, 2017-04-13 04:10:38]

Description was changed from

==========
Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin
==========

to

==========
Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2815743002
Cr-Commit-Position: refs/heads/master@{#464290}
Committed:
https://chromium.googlesource.com/chromium/src/+/343665e7bad5f7f1b01b8bfec116...
==========

[commit-bot: I haz the power, 2017-04-13 04:10:40]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/343665e7bad5f7f1b01b8bfec116...