Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: components/payments/content/payment_request.cc

Issue 2815723002: [Web Payments] Add Spinners and timeout while waiting for UpdateWith (Closed)
Patch Set: Remove timer. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/content/payment_request.cc
diff --git a/components/payments/content/payment_request.cc b/components/payments/content/payment_request.cc
index 15aee2c679179aa5b8350baa43e647edde7dd14a..65d013a88bdc2cef7b8517488aa8be1ef345bb15 100644
--- a/components/payments/content/payment_request.cc
+++ b/components/payments/content/payment_request.cc
@@ -125,11 +125,15 @@ void PaymentRequest::OnPaymentResponseAvailable(
void PaymentRequest::OnShippingOptionIdSelected(
std::string shipping_option_id) {
+ spec_->StartWaitingForUpdateWith(
Mathieu 2017/04/13 15:35:29 What do you think about putting this in PaymentReq
anthonyvd 2017/04/13 21:05:59 Yeah makes sense. It was here because of the timer
+ PaymentRequestSpec::UpdateReason::SHIPPING_OPTION);
client_->OnShippingOptionChange(shipping_option_id);
}
void PaymentRequest::OnShippingAddressSelected(
mojom::PaymentAddressPtr address) {
+ spec_->StartWaitingForUpdateWith(
Mathieu 2017/04/13 15:35:29 Similarly in PaymentRequestState::SetSelectedShipp
anthonyvd 2017/04/13 21:05:59 Done.
+ PaymentRequestSpec::UpdateReason::SHIPPING_ADDRESS);
client_->OnShippingAddressChange(std::move(address));
}

Powered by Google App Engine
This is Rietveld 408576698