[Web Payments] Add Spinners and timeout while waiting for UpdateWith

components/payments/content/payment_request.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_request.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 107 matching lines @@
   OnConnectionTerminated();
 }
 
 void PaymentRequest::OnPaymentResponseAvailable(
     mojom::PaymentResponsePtr response) {
   client_->OnPaymentResponse(std::move(response));
 }
 
 void PaymentRequest::OnShippingOptionIdSelected(
     std::string shipping_option_id) {
+  spec_->StartWaitingForUpdateWith(

[Mathieu, 2017/04/13 15:35:29]

What do you think about putting this in
PaymentRequestState::SetSelectedShippingOption (before delegate_-> is called)? I
would like to avoid too much UI-type logic in here, and just keep what's
required for the mojo interaction.

[anthonyvd, 2017/04/13 21:05:59]

Yeah makes sense. It was here because of the timer, which doesn't exist anymore.

+      PaymentRequestSpec::UpdateReason::SHIPPING_OPTION);
   client_->OnShippingOptionChange(shipping_option_id);
 }
 
 void PaymentRequest::OnShippingAddressSelected(
     mojom::PaymentAddressPtr address) {
+  spec_->StartWaitingForUpdateWith(

[Mathieu, 2017/04/13 15:35:29]

Similarly in PaymentRequestState::SetSelectedShippingProfile

[anthonyvd, 2017/04/13 21:05:59]

Done.

+      PaymentRequestSpec::UpdateReason::SHIPPING_ADDRESS);
   client_->OnShippingAddressChange(std::move(address));
 }
 
 void PaymentRequest::UserCancelled() {
   // If |client_| is not bound, then the object is already being destroyed as
   // a result of a renderer event.
   if (!client_.is_bound())
     return;
 
   // This sends an error to the renderer, which informs the API user.
@@ skipping 15 matching lines @@
   binding_.Close();
   delegate_->CloseDialog();
   manager_->DestroyRequest(this);
 }
 
 void PaymentRequest::Pay() {
   state_->GeneratePaymentResponse();
 }
 
 }  // namespace payments