Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2815713004: Harmony - Dialog-specific conversion for Add to Desktop. (Closed)

Created:
3 years, 8 months ago by Bret
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmony - Dialog-specific conversion for Add to Desktop. Add to Desktop requires a layout rewrite for Harmony. This patch takes care of that part of the conversion, though the dialog won't be ready for review yet due to needing some general changes. BUG=652510 Review-Url: https://codereview.chromium.org/2815713004 Cr-Commit-Position: refs/heads/master@{#464785} Committed: https://chromium.googlesource.com/chromium/src/+/bebfdd95c7fdc587686da076262cb9292696e909

Patch Set 1 #

Patch Set 2 : minor changes #

Patch Set 3 : fix merge with allen's patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc View 1 2 4 chunks +34 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/harmony/chrome_layout_provider.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/chrome_layout_provider.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_provider.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Bret
3 years, 8 months ago (2017-04-12 00:05:55 UTC) #2
Peter Kasting
LGTM, but I suggest trying to let Allen land his LayoutDelegate refactor first, since it ...
3 years, 8 months ago (2017-04-13 00:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815713004/40001
3 years, 8 months ago (2017-04-14 00:42:49 UTC) #6
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-14 01:38:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815713004/40001
3 years, 8 months ago (2017-04-14 20:12:01 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 20:18:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bebfdd95c7fdc587686da076262c...

Powered by Google App Engine
This is Rietveld 408576698