IPH - connect data saver previews

chrome/browser/previews/previews_infobar_tab_helper.cc

Index: chrome/browser/previews/previews_infobar_tab_helper.cc
diff --git a/chrome/browser/previews/previews_infobar_tab_helper.cc b/chrome/browser/previews/previews_infobar_tab_helper.cc
index 917d3ebfe75f971b74c06c06e12e3d47bda40eee..78c8295c357af1a6d332a2c31da1e762e36de35b 100644
--- a/chrome/browser/previews/previews_infobar_tab_helper.cc
+++ b/chrome/browser/previews/previews_infobar_tab_helper.cc
@@ -6,6 +6,7 @@
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
+#include "chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/previews/previews_infobar_delegate.h"
@@ -14,6 +15,8 @@
 #include "chrome/browser/profiles/profile.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
+#include "components/feature_engagement_tracker/public/event_constants.h"
+#include "components/feature_engagement_tracker/public/feature_engagement_tracker.h"
 #include "components/previews/core/previews_experiments.h"
 #include "components/previews/core/previews_ui_service.h"
 #include "content/public/browser/browser_context.h"
@@ -75,6 +78,13 @@ void PreviewsInfoBarTabHelper::DidFinishNavigation(
       // TODO(ryansturm): Add UMA for errors.
       return;
     }
+
+    feature_engagement_tracker::FeatureEngagementTracker* tracker =

[gone, 2017/04/18 21:05:19]

Maybe this should be called after the infobar delegate is created?

[David Trainor- moved to gerrit, 2017/04/25 05:01:05]

Ideally we want the precondition events to be fired before we query them to see
if we should show the IPH dialog.  In this case, it's a little odd.  We're
saying, "Log that we've shown a preview."  Then in the infobar we're effectively
asking, "Did we show a preview and should I show?"  It's odd because the event
and the triggering condition are almost the same here.

+        FeatureEngagementTrackerFactory::GetInstance()->GetForBrowserContext(
+            web_contents()->GetBrowserContext());
+    tracker->NotifyEvent(
+        feature_engagement_tracker::kIPHEventDataSaverPreviewOpened);
+
     data_reduction_proxy::DataReductionProxySettings*
         data_reduction_proxy_settings =
             DataReductionProxyChromeSettingsFactory::GetForBrowserContext(