IPH - connect data saver previews

chrome/browser/previews/previews_infobar_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/previews/previews_infobar_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
+#include "chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/previews/previews_infobar_delegate.h"
 #include "chrome/browser/previews/previews_service.h"
 #include "chrome/browser/previews/previews_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
+#include "components/feature_engagement_tracker/public/event_constants.h"
+#include "components/feature_engagement_tracker/public/feature_engagement_tracker.h"
 #include "components/previews/core/previews_experiments.h"
 #include "components/previews/core/previews_ui_service.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "net/http/http_response_headers.h"
 #include "url/gurl.h"
 
@@ skipping 41 matching lines @@
 
 #if defined(OS_ANDROID)
   offline_pages::OfflinePageTabHelper* tab_helper =
       offline_pages::OfflinePageTabHelper::FromWebContents(web_contents());
 
   if (tab_helper && tab_helper->IsShowingOfflinePreview()) {
     if (navigation_handle->IsErrorPage()) {
       // TODO(ryansturm): Add UMA for errors.
       return;
     }
+
+    feature_engagement_tracker::FeatureEngagementTracker* tracker =

[gone, 2017/04/18 21:05:19]

Maybe this should be called after the infobar delegate is created?

[David Trainor- moved to gerrit, 2017/04/25 05:01:05]

Ideally we want the precondition events to be fired before we query them to see
if we should show the IPH dialog.  In this case, it's a little odd.  We're
saying, "Log that we've shown a preview."  Then in the infobar we're effectively
asking, "Did we show a preview and should I show?"  It's odd because the event
and the triggering condition are almost the same here.

+        FeatureEngagementTrackerFactory::GetInstance()->GetForBrowserContext(
+            web_contents()->GetBrowserContext());
+    tracker->NotifyEvent(
+        feature_engagement_tracker::kIPHEventDataSaverPreviewOpened);
+
     data_reduction_proxy::DataReductionProxySettings*
         data_reduction_proxy_settings =
             DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
                 web_contents()->GetBrowserContext());
     PreviewsInfoBarDelegate::Create(
         web_contents(), PreviewsInfoBarDelegate::OFFLINE,
         data_reduction_proxy_settings &&
             data_reduction_proxy_settings->IsDataReductionProxyEnabled(),
         base::Bind(
             &AddPreviewNavigationCallback, web_contents()->GetBrowserContext(),
             navigation_handle->GetURL(), previews::PreviewsType::OFFLINE));
     // Don't try to show other infobars if this is an offline preview.
     return;
   }
 #endif  // defined(OS_ANDROID)
 
   const net::HttpResponseHeaders* headers =
       navigation_handle->GetResponseHeaders();
   if (headers && data_reduction_proxy::IsLitePagePreview(*headers)) {
     PreviewsInfoBarDelegate::Create(
         web_contents(), PreviewsInfoBarDelegate::LITE_PAGE,
         true /* is_data_saver_user */,
         PreviewsInfoBarDelegate::OnDismissPreviewsInfobarCallback());
   }
 }