Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2815643007: TemplateURLService: notify observers of shutdown (Closed)

Created:
3 years, 8 months ago by Marc Treib
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TemplateURLService: notify observers of shutdown This allows observers that might outlive the service to unregister themselves, and to clear out any raw pointers to the service they might have. In the same spirit, verify that there are no observers left during TemplateURLService destruction. BUG=704518 Review-Url: https://codereview.chromium.org/2815643007 Cr-Commit-Position: refs/heads/master@{#464351} Committed: https://chromium.googlesource.com/chromium/src/+/9f5ce2d4fb3d35f5b2b22ad4f486d93b0d1acd50

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 3

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/search_engines/template_url_service.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service_observer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
Marc Treib
PTAL! See the dependent CL (https://codereview.chromium.org/2805133004) for what motivated this. Thanks! https://codereview.chromium.org/2815643007/diff/20001/components/search_engines/template_url_service.cc File components/search_engines/template_url_service.cc (right): ...
3 years, 8 months ago (2017-04-12 11:56:06 UTC) #10
Peter Kasting
LGTM https://codereview.chromium.org/2815643007/diff/20001/components/search_engines/template_url_service.h File components/search_engines/template_url_service.h (right): https://codereview.chromium.org/2815643007/diff/20001/components/search_engines/template_url_service.h#newcode774 components/search_engines/template_url_service.h:774: base::ObserverList<TemplateURLServiceObserver, true> model_observers_; I don't think we should ...
3 years, 8 months ago (2017-04-13 00:03:37 UTC) #11
Marc Treib
Thanks! https://codereview.chromium.org/2815643007/diff/20001/components/search_engines/template_url_service.h File components/search_engines/template_url_service.h (right): https://codereview.chromium.org/2815643007/diff/20001/components/search_engines/template_url_service.h#newcode774 components/search_engines/template_url_service.h:774: base::ObserverList<TemplateURLServiceObserver, true> model_observers_; On 2017/04/13 00:03:36, Peter Kasting ...
3 years, 8 months ago (2017-04-13 08:07:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815643007/40001
3 years, 8 months ago (2017-04-13 09:01:38 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 09:09:01 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f5ce2d4fb3d35f5b2b22ad4f486...

Powered by Google App Engine
This is Rietveld 408576698