Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2815643005: Remove patch which has been rolled in from libxml2 upstream. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Oliver Chang
CC:
ail_google.com, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove patch which has been rolled in from libxml2 upstream. Upstream commit 90ccb58242866b0ba3edbef8fe44214a101c2b3e includes this patch; our local patch was redundantly reapplied causing a null-deref. This turns down the fuzz factor on the roll script to zero from the default of two. In this particular case a fuzz factor <= 1 would have been sufficient to barf on this. The next roll may want to turn this up again to one and/or update the context of patches. BUG=710365 Review-Url: https://codereview.chromium.org/2815643005 Cr-Commit-Position: refs/heads/master@{#463938} Committed: https://chromium.googlesource.com/chromium/src/+/4b0720728483b544dad1aa6a0060ea01cd5519e3

Patch Set 1 #

Patch Set 2 : Also decrease the fuzz factor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -32 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7375-xmlParsePEReference-xxe.patch View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/libxml/chromium/roll.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libxml/src/parser.c View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 8 months ago (2017-04-12 04:24:18 UTC) #9
Oliver Chang
LGTM
3 years, 8 months ago (2017-04-12 05:09:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815643005/20001
3 years, 8 months ago (2017-04-12 05:12:20 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 05:53:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b0720728483b544dad1aa6a0060...

Powered by Google App Engine
This is Rietveld 408576698