Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2815623003: Revert of [DeviceService] Add service tests for VibrationManager. (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DeviceService] Add service tests for VibrationManager. (patchset #7 id:410001 of https://codereview.chromium.org/2774783003/ ) Reason for revert: Appears to have broken service_unittests on Nexus 5X. Original issue's description: > [DeviceService] Add service tests for VibrationManager. > > VibrationManagerImpl.java is in //device/vibration while the > VibrationManagerImplTest.java is still in //content, > to be able to hide all //device/vibration impl inside Device Service, > we must eliminate this concrete dependency on //device/vibration from > content layer. > > As VibrationManagerImplTest.java is an integration test based on > content shell test infra, we can't move it outside of //content. > So we consider to use other tests to replace it, while the renderer-side > testing has already been covered by layout tests created at > https://codereview.chromium.org/2731953003/, so we create this CL to > cover the VibrationManager interface impl testing: > - creates an infra for Device Service service tests. > - adds a new service test for VibrationManager interface. > > Then after this CL we'll be able to hide all vibration impl inside > Device Service with a follow-up CL. > > BUG=689379 > TEST=service_unittests > > Review-Url: https://codereview.chromium.org/2774783003 > Cr-Commit-Position: refs/heads/master@{#463612} > Committed: https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbeaab719015761 TBR=rockot@chromium.org,avi@chromium.org,blundell@chromium.org,jam@chromium.org,timvolodine@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689379 Review-Url: https://codereview.chromium.org/2815623003 Cr-Commit-Position: refs/heads/master@{#463629} Committed: https://chromium.googlesource.com/chromium/src/+/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -335 lines) Patch
M content/public/android/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/VibrationManagerImplTest.java View 1 chunk +128 lines, -0 lines 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java View 5 chunks +28 lines, -29 lines 0 comments Download
M device/vibration/vibration_manager_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/vibration/vibration_manager_impl_default.cc View 2 chunks +1 line, -8 lines 0 comments Download
M services/BUILD.gn View 2 chunks +2 lines, -5 lines 0 comments Download
M services/device/BUILD.gn View 6 chunks +4 lines, -54 lines 0 comments Download
D services/device/device_service_test_base.h View 1 chunk +0 lines, -28 lines 0 comments Download
D services/device/device_service_test_base.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D services/device/unittest_manifest.json View 1 chunk +0 lines, -16 lines 0 comments Download
D services/device/vibration/vibration_manager_impl_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M services/service_manager/public/cpp/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/test/run_all_service_tests.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
please use gerrit instead
Created Revert of [DeviceService] Add service tests for VibrationManager.
3 years, 8 months ago (2017-04-11 14:45:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815623003/1
3 years, 8 months ago (2017-04-11 14:45:52 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 14:47:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a5a2cdc76662f6e8fa8bb70ee9a...

Powered by Google App Engine
This is Rietveld 408576698