Validate page load in testBrowsingPostEntryWithKeyboard with web view text.

Validate page load in testBrowsingPostEntryWithKeyboard with web view text.

The testBrowsingPostEntryWithKeyboard test currently uses the
waitForPageToFinishLoading API to ensure that the page is loaded before
validating omnibox text. But, this is not sufficient to prevent flake as the page 
load may not have started at this point. This CL resolves the flake by waiting for
and validating that the web view has text from the target page instead.

BUG=704618
Review-Url: https://codereview.chromium.org/2815503002
Cr-Commit-Position: refs/heads/master@{#463484}
Committed: https://chromium.googlesource.com/chromium/src/+/24a7ab49adbbaeefd815066ac9e530e4713560b1

[gchatz, 2017-04-11 00:12:01]

Description was changed from

==========
Make testBrowsingPostEntryWithKeyboard wait for text in web view.

The testBrowsingPostEntryWithKeyboard test currently uses the
waitForPageToFinishLoading API to ensure that the page is loaded before
validating that the load completed successfully. But, this is not
sufficient to prevent flake as the page load may not have started by
the wait. This CL resolves the flake by switching to validate that
the web view has text from the destination page in it before validating
the omnibox text.

BUG=704618
==========

to

==========
Validate page load in testBrowsingPostEntryWithKeyboard with web view text.

The testBrowsingPostEntryWithKeyboard test currently uses the
waitForPageToFinishLoading API to ensure that the page is loaded before
validating omnibox text. But, this is not sufficient to prevent flake as the
page 
load may not have started at this point. This CL resolves the flake by waiting
for
and validating that the web view has text from the target page instead.

BUG=704618
==========

[gchatz, 2017-04-11 00:14:01]

gchatz@chromium.org changed reviewers:
+ eugenebut@chromium.org

[gchatz, 2017-04-11 00:14:01]

I am leaving this in browsing_egtest for now. Will move over to forms_egtest in
a follow up. This test may not integrate as nicely with
the classes in forms_egtest, since the form here has a text field instead of a
textarea.

[Eugene But (OOO till 7-30), 2017-04-11 00:57:04]

lgtm

https://codereview.chromium.org/2815503002/diff/1/ios/chrome/browser/web/brow...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2815503002/diff/1/ios/chrome/browser/web/brow...
ios/chrome/browser/web/browsing_egtest.mm:608: -
(void)FLAKY_testBrowsingPostEntryWithKeyboard {
Do you plan to remove |FLAKY_| in a separate CL?

[gchatz, 2017-04-11 01:03:58]

https://codereview.chromium.org/2815503002/diff/1/ios/chrome/browser/web/brow...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2815503002/diff/1/ios/chrome/browser/web/brow...
ios/chrome/browser/web/browsing_egtest.mm:608: -
(void)FLAKY_testBrowsingPostEntryWithKeyboard {
On 2017/04/11 00:57:04, Eugene But wrote:
> Do you plan to remove |FLAKY_| in a separate CL?

Yep, after verifying this fix worked.

[gchatz, 2017-04-11 01:04:03]

The CQ bit was checked by gchatz@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:04:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:17:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491872643934630, "parent_rev":
"df6cb72c647e93cb1ae1668e255ea0ce8aef5779", "commit_rev":
"24a7ab49adbbaeefd815066ac9e530e4713560b1"}

[commit-bot: I haz the power, 2017-04-11 01:18:12]

Description was changed from

==========
Validate page load in testBrowsingPostEntryWithKeyboard with web view text.

The testBrowsingPostEntryWithKeyboard test currently uses the
waitForPageToFinishLoading API to ensure that the page is loaded before
validating omnibox text. But, this is not sufficient to prevent flake as the
page 
load may not have started at this point. This CL resolves the flake by waiting
for
and validating that the web view has text from the target page instead.

BUG=704618
==========

to

==========
Validate page load in testBrowsingPostEntryWithKeyboard with web view text.

The testBrowsingPostEntryWithKeyboard test currently uses the
waitForPageToFinishLoading API to ensure that the page is loaded before
validating omnibox text. But, this is not sufficient to prevent flake as the
page 
load may not have started at this point. This CL resolves the flake by waiting
for
and validating that the web view has text from the target page instead.

BUG=704618

Review-Url: https://codereview.chromium.org/2815503002
Cr-Commit-Position: refs/heads/master@{#463484}
Committed:
https://chromium.googlesource.com/chromium/src/+/24a7ab49adbbaeefd815066ac9e5...
==========

[commit-bot: I haz the power, 2017-04-11 01:18:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24a7ab49adbbaeefd815066ac9e5...