Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2815463003: More code-like comment in browser_thread.h for TaskScheduler migration. (Closed)

Created:
3 years, 8 months ago by gab
Modified:
3 years, 8 months ago
Reviewers:
jam, brucedawson
CC:
chromium-reviews, jam, darin-cc_chromium.org, brucedawson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

More code-like comment in browser_thread.h for TaskScheduler migration. For them to compile when copy-pasted (proper base:: prefixes and avoiding english logic in code example). BUG=667892 NOTRY=true Review-Url: https://codereview.chromium.org/2815463003 Cr-Commit-Position: refs/heads/master@{#464399} Committed: https://chromium.googlesource.com/chromium/src/+/2d34f19ee2368eee2579fd0a77762e23122de025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/public/browser/browser_thread.h View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gab
John, as requested, PTaL
3 years, 8 months ago (2017-04-11 19:06:42 UTC) #3
brucedawson
That addresses my concerns. lgtm
3 years, 8 months ago (2017-04-11 19:36:40 UTC) #5
jam
lgtm, thanks
3 years, 8 months ago (2017-04-11 23:23:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815463003/1
3 years, 8 months ago (2017-04-13 14:08:21 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 14:24:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d34f19ee2368eee2579fd0a7776...

Powered by Google App Engine
This is Rietveld 408576698